You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/06/02 23:35:00 UTC
Review Request 34954: DRILL-3196: Disable multiple partition by
clauses in the same sql query
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34954/
-----------------------------------------------------------
Review request for drill and Aman Sinha.
Bugs: DRILL-3196
https://issues.apache.org/jira/browse/DRILL-3196
Repository: drill-git
Description
-------
After validation, detech if there is no than one partition
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java PRE-CREATION
Diff: https://reviews.apache.org/r/34954/diff/
Testing
-------
All the requested tests
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 34954: DRILL-3196: Disable multiple partition by
clauses in the same sql query
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34954/#review87233
-----------------------------------------------------------
Ship it!
Ship It!
- Aman Sinha
On June 9, 2015, 5:24 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34954/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 5:24 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3196
> https://issues.apache.org/jira/browse/DRILL-3196
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> After validation, detech if there is no than one partition
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
> exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34954/diff/
>
>
> Testing
> -------
>
> All the requested tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 34954: DRILL-3196: Disable multiple partition by
clauses in the same sql query
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34954/
-----------------------------------------------------------
(Updated June 9, 2015, 5:24 p.m.)
Review request for drill and Aman Sinha.
Changes
-------
Updated the patch
Bugs: DRILL-3196
https://issues.apache.org/jira/browse/DRILL-3196
Repository: drill-git
Description
-------
After validation, detech if there is no than one partition
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java PRE-CREATION
Diff: https://reviews.apache.org/r/34954/diff/
Testing
-------
All the requested tests
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 34954: DRILL-3196: Disable multiple partition by
clauses in the same sql query
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34954/
-----------------------------------------------------------
(Updated June 6, 2015, 12:39 a.m.)
Review request for drill and Aman Sinha.
Changes
-------
A new patch
Bugs: DRILL-3196
https://issues.apache.org/jira/browse/DRILL-3196
Repository: drill-git
Description
-------
After validation, detech if there is no than one partition
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java PRE-CREATION
Diff: https://reviews.apache.org/r/34954/diff/
Testing
-------
All the requested tests
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 34954: DRILL-3196: Disable multiple partition by
clauses in the same sql query
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
> On June 6, 2015, midnight, Aman Sinha wrote:
> > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java, line 26
> > <https://reviews.apache.org/r/34954/diff/1/?file=976828#file976828line26>
> >
> > It would be good to add 1 test where there are 2 window functions with the same partition-by but different order-by column. I believe this should also throw unsupported exception.
A test case is added:
select sum(a2) over(partition by a2 order by a2), count(*) over(partition by a2 order by b2) from ...
Notice that the two over clauses differ by ORDER BY only.
> On June 6, 2015, midnight, Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java, line 126
> > <https://reviews.apache.org/r/34954/diff/1/?file=976827#file976827line126>
> >
> > There's some confusion about what exactly multiple-partition means. Is it multiple columns in a single partition-by or different columns in 2 or more partition-by clauses. Also, the error should represent something about different order-by criteria not supported.
I changed it to this:
Multiple windows defined in a single select list is not supported
- Sean Hsuan-Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34954/#review86868
-----------------------------------------------------------
On June 6, 2015, 12:39 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34954/
> -----------------------------------------------------------
>
> (Updated June 6, 2015, 12:39 a.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3196
> https://issues.apache.org/jira/browse/DRILL-3196
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> After validation, detech if there is no than one partition
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
> exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34954/diff/
>
>
> Testing
> -------
>
> All the requested tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 34954: DRILL-3196: Disable multiple partition by
clauses in the same sql query
Posted by Aman Sinha <as...@maprtech.com>.
> On June 6, 2015, midnight, Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java, line 126
> > <https://reviews.apache.org/r/34954/diff/1/?file=976827#file976827line126>
> >
> > There's some confusion about what exactly multiple-partition means. Is it multiple columns in a single partition-by or different columns in 2 or more partition-by clauses. Also, the error should represent something about different order-by criteria not supported.
>
> Sean Hsuan-Yi Chu wrote:
> I changed it to this:
> Multiple windows defined in a single select list is not supported
Can you pls change this to 'Multiple window definitions in a single SELECT list is not currently supported'
- Aman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34954/#review86868
-----------------------------------------------------------
On June 6, 2015, 12:39 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34954/
> -----------------------------------------------------------
>
> (Updated June 6, 2015, 12:39 a.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3196
> https://issues.apache.org/jira/browse/DRILL-3196
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> After validation, detech if there is no than one partition
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
> exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34954/diff/
>
>
> Testing
> -------
>
> All the requested tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 34954: DRILL-3196: Disable multiple partition by
clauses in the same sql query
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34954/#review86868
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
<https://reviews.apache.org/r/34954/#comment139001>
There's some confusion about what exactly multiple-partition means. Is it multiple columns in a single partition-by or different columns in 2 or more partition-by clauses. Also, the error should represent something about different order-by criteria not supported.
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java
<https://reviews.apache.org/r/34954/#comment138996>
It would be good to add 1 test where there are 2 window functions with the same partition-by but different order-by column. I believe this should also throw unsupported exception.
- Aman Sinha
On June 2, 2015, 9:35 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34954/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 9:35 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3196
> https://issues.apache.org/jira/browse/DRILL-3196
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> After validation, detech if there is no than one partition
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
> exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34954/diff/
>
>
> Testing
> -------
>
> All the requested tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>