You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2023/01/05 11:06:35 UTC
[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4097: bump pom parent from apache 27 to 29 and align maven plugin version to parent
bowenliang123 opened a new pull request, #4097:
URL: https://github.com/apache/kyuubi/pull/4097
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Apache Parent Pom changes:
- 27 vs 29 https://github.com/apache/maven-apache-parent/compare/apache-27...apache-29
Maven plugin differ:
<html xmlns:x="tencent"><meta charset="utf-8"><style type='text/css'><!-- td { empty-cells:show;line-height:normal;color:#000;vertical-align:middle;outline-width:0;word-wrap:break-word;word-break:normal;white-space:nowrap; text-align:left;font-size:10pt; } table { border-collapse: collapse; } font{ white-space: pre-wrap }--></style><body><!--StartFragment-->
maven plugin name | previous version | version in apache pom parent 29 | updated / unchanged
-- | -- | -- | --
antrun | 3.0.0 | 3.1.0 |
assembly | 3.2.0 | 3.4.2 |
clean | 3.1.0 | 3.2.0 |
compiler | 3.8.1 | 3.10.1 |
dependency | 3.1.1 | 3.4.0 |
deply | 3.0.0-M1 | 2.8.2 |
gpg | 3.0.1 | 3.0.1 |
javadoc | 3.3.0 | 3.4.4 |
help | 3.2.0 | 3.3.0 |
jar | 3.2.0 | 3.3.0 |
shade | 3.4.1 | 3.4.1 | unchanged
rat | 0.13 | 0.15 |
source | 3.2.1 | 3.2.1 | unchanged
<!--EndFragment--></body></html>
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4097: bump pom parent from apache 27 to 29 and align maven plugin versions to parent
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4097:
URL: https://github.com/apache/kyuubi/pull/4097#issuecomment-1372088161
We can benefit from https://github.com/apache/maven-apache-parent/commit/a7af870e9b3b7a5375f09948ab7fdf9c7709048e to simplify the `pom.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4097: bump pom parent from apache 27 to 29 and align maven plugin versions to parent
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4097:
URL: https://github.com/apache/kyuubi/pull/4097#discussion_r1062364309
##########
pom.xml:
##########
@@ -1899,25 +1885,21 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>${maven.plugin.shade.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
- <version>${maven.plugin.jar.version}</version>
</plugin>
Review Comment:
we can remove the simple definition in the `dependencyManagement` block then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4097: bump pom parent from apache 27 to 29 and align maven plugin versions to parent
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4097:
URL: https://github.com/apache/kyuubi/pull/4097#issuecomment-1372085303
It's preferred to manage the `maven-shade-plugin` explicitly since it's bugly, silent version change of this plugin is dangerous. For other plugins, I'm fine to use the version defined in the parent pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4097: Bump pom parent from apache 27 to 29 and align maven plugin versions to parent
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #4097:
URL: https://github.com/apache/kyuubi/pull/4097#issuecomment-1372115456
> It's preferred to manage the `maven-shade-plugin` explicitly since it's bugly, silent version change of this plugin is dangerous. For other plugins, I'm fine to use the version defined in the parent pom.
Pinned `maven-shade-plugin` to 3.4.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4097: bump pom parent from apache 27 to 29 and align maven plugin versions to parent
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on code in PR #4097:
URL: https://github.com/apache/kyuubi/pull/4097#discussion_r1062373429
##########
pom.xml:
##########
@@ -1899,25 +1885,21 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>${maven.plugin.shade.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
- <version>${maven.plugin.jar.version}</version>
</plugin>
Review Comment:
Yes, agree. Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #4097: Align maven plugin versions to Apache parent pom bumped to version 29
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #4097: Align maven plugin versions to Apache parent pom bumped to version 29
URL: https://github.com/apache/kyuubi/pull/4097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4097: Align maven plugin versions to Apache parent pom bumped to version 29
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4097:
URL: https://github.com/apache/kyuubi/pull/4097#issuecomment-1372249276
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4097: Bump pom parent from apache 27 to 29 and align maven plugin versions to parent
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4097:
URL: https://github.com/apache/kyuubi/pull/4097#issuecomment-1372117507
> > We can benefit from [apache/maven-apache-parent@a7af870](https://github.com/apache/maven-apache-parent/commit/a7af870e9b3b7a5375f09948ab7fdf9c7709048e) to simplify the `pom.xml`
>
> Sure, let's do the property alignment in the followup PR to make use of them.
After second thought, it's not enough since we can not overwrite `distMgmtReleaseId` and `distMgmtSnapshotsId` after changing, it may cause authentication issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4097: bump pom parent from apache 27 to 29 and align maven plugin versions to parent
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #4097:
URL: https://github.com/apache/kyuubi/pull/4097#issuecomment-1372113244
> We can benefit from [apache/maven-apache-parent@a7af870](https://github.com/apache/maven-apache-parent/commit/a7af870e9b3b7a5375f09948ab7fdf9c7709048e) to simplify the `pom.xml`
Sure, let's do the property alignment in the followup PR to make use of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4097: bump pom parent from apache 27 to 29 and align maven plugin versions to parent
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on code in PR #4097:
URL: https://github.com/apache/kyuubi/pull/4097#discussion_r1062373429
##########
pom.xml:
##########
@@ -1899,25 +1885,21 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>${maven.plugin.shade.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
- <version>${maven.plugin.jar.version}</version>
</plugin>
Review Comment:
Yes, agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org