You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/18 23:52:20 UTC
Review Request 19335: Force disable C++11 in libprocess for g++-4.7.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19335/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs
-----
3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
3rdparty/libprocess/m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19335/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19335: Force disable C++11 in libprocess for g++-4.7.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19335/#review37911
-----------------------------------------------------------
Can you update this as per the comments in https://reviews.apache.org/r/19336 please?
- Benjamin Hindman
On March 19, 2014, 12:28 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19335/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 12:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
> 3rdparty/libprocess/m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19335/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19335: Force disable C++11 in libprocess for g++-4.7.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19335/#review37693
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19335]
All tests passed.
- Mesos ReviewBot
On March 19, 2014, 12:28 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19335/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 12:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
> 3rdparty/libprocess/m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19335/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19335: Force disable C++11 in libprocess for g++-4.7.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19335/#review37940
-----------------------------------------------------------
Ship it!
I'll be committing this now.
- Benjamin Hindman
On March 20, 2014, 5:46 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19335/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 5:46 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
> 3rdparty/libprocess/m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19335/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19335: Force disable C++11 in libprocess for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19335/
-----------------------------------------------------------
(Updated March 20, 2014, 10:46 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
3rdparty/libprocess/m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19335/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19335: Force disable C++11 in libprocess for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19335/
-----------------------------------------------------------
(Updated March 18, 2014, 5:28 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
3rdparty/libprocess/m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19335/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19335: Force disable C++11 in libprocess for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19335/
-----------------------------------------------------------
(Updated March 18, 2014, 5:26 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
3rdparty/libprocess/m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19335/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19335: Force disable C++11 in libprocess for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19335/
-----------------------------------------------------------
(Updated March 18, 2014, 4:30 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
rebased to master
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
3rdparty/libprocess/m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19335/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19335: Force disable C++11 in libprocess for g++-4.7.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19335/#review37662
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 18, 2014, 11:24 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19335/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 11:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
> 3rdparty/libprocess/m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19335/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19335: Force disable C++11 in libprocess for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19335/
-----------------------------------------------------------
(Updated March 18, 2014, 4:24 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
3rdparty/libprocess/m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19335/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon