You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datafu.apache.org by wang jian <ki...@gmail.com> on 2014/03/02 13:35:20 UTC

Review Request 18670: Add unit test for AliasEvalFunc based on JIRA https://issues.apache.org/jira/browse/DATAFU-33

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18670/
-----------------------------------------------------------

Review request for DataFu.


Repository: datafu


Description
-------

Add a unit test for AliasEvalFunc.


Diffs
-----

  test/pig/datafu/test/pig/util/AliasEvalFuncTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/18670/diff/


Testing
-------


Thanks,

wang jian


Re: Review Request 18670: Add unit test for AliasEvalFunc based on JIRA https://issues.apache.org/jira/browse/DATAFU-33

Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18670/#review35932
-----------------------------------------------------------

Ship it!


Ship It!

- Matthew Hayes


On March 2, 2014, 12:35 p.m., wang jian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18670/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 12:35 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> Add a unit test for AliasEvalFunc.
> 
> 
> Diffs
> -----
> 
>   test/pig/datafu/test/pig/util/AliasEvalFuncTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18670/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wang jian
> 
>


Re: Review Request 18670: Add unit test for AliasEvalFunc based on JIRA https://issues.apache.org/jira/browse/DATAFU-33

Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18670/#review35915
-----------------------------------------------------------


+1

Looks good to me, can you attach the patch to the jira?

- Matthew Hayes


On March 2, 2014, 12:35 p.m., wang jian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18670/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 12:35 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> Add a unit test for AliasEvalFunc.
> 
> 
> Diffs
> -----
> 
>   test/pig/datafu/test/pig/util/AliasEvalFuncTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18670/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wang jian
> 
>