You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Jedore (via GitHub)" <gi...@apache.org> on 2023/04/23 08:58:24 UTC
[GitHub] [skywalking-python] Jedore opened a new pull request, #302: Optimize loguru reporter plugin
Jedore opened a new pull request, #302:
URL: https://github.com/apache/skywalking-python/pull/302
Optimize the loguru reporter plugin.
- [x] Update the [`CHANGELOG.md`](https://github.com/apache/skywalking-python/blob/master/CHANGELOG.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #302: Optimize loguru reporter plugin
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1520991375
Should be in 1.0.1 or pending?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #302: Optimize loguru reporter plugin
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1519412422
Thanks for fixing it, great work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #302: Optimize loguru reporter plugin
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1520993249
> Should be in 1.0.1 or pending?
This PR also fixes a potential reporter bug introduced in 1.0.0, so it will be included in the 1.0.1 patch. But no further features will be added beyond this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #302: Optimize loguru reporter plugin
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1519412787
The oap container in kafka e2e cases fails and it's not your problem. I'm investigating now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Jedore commented on pull request #302: Optimize loguru reporter plugin
Posted by "Jedore (via GitHub)" <gi...@apache.org>.
Jedore commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1519411582
It's my error. I have commited new fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #302: Optimize loguru reporter plugin
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1521096912
Great, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Jedore commented on pull request #302: Optimize loguru reporter plugin
Posted by "Jedore (via GitHub)" <gi...@apache.org>.
Jedore commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1519293198
Seems the error is:
```
- text: '2023-04-24 02:08:51.207 | WARNING | __main__:application:44 - Loguru - provider warning reported.
+ text: Loguru provider warning reported.
```
and
https://github.com/apache/skywalking-python/actions/runs/4781572067/jobs/8500362225?pr=302#step:6:764
I test in my own repo as metioned in https://github.com/apache/skywalking/discussions/10723 after simpling the loguru test https://github.com/Jedore/skywalking-python/blob/ttt/tests/plugin/data/sw_loguru/services/provider.py.
So i think may be the key is skywalking-agent-test-tool syntax `end with` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #302: Optimize loguru reporter plugin
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1519431017
I see the problem, Kraft mode became default in our pulled bitnami kafka image and the configuration isn't enough for it. I will start another PR later today to fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #302: Optimize loguru reporter plugin
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1520911185
LGTM and once the other PR is merged this one can merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy merged pull request #302: Optimize loguru reporter plugin
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy merged PR #302:
URL: https://github.com/apache/skywalking-python/pull/302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #302: Optimize loguru reporter plugin
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1521009780
CI is still failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #302: Optimize loguru reporter plugin
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1521028887
> CI is still failing.
GHA runners are not working properly, let's wait a bit and see if it passes. https://www.githubstatus.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #302: Optimize loguru reporter plugin
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #302:
URL: https://github.com/apache/skywalking-python/pull/302#issuecomment-1521028453
GitHub actions is not working properly https://www.githubstatus.com/ let's wait a bit and see if it passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org