You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2006/03/13 00:14:56 UTC

svn commit: r385387 - /jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java

Author: sebb
Date: Sun Mar 12 15:14:56 2006
New Revision: 385387

URL: http://svn.apache.org/viewcvs?rev=385387&view=rev
Log:
Bug 18359 - avoid double encoding

Modified:
    jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java

Modified: jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java
URL: http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java?rev=385387&r1=385386&r2=385387&view=diff
==============================================================================
--- jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java (original)
+++ jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java Sun Mar 12 15:14:56 2006
@@ -220,6 +220,7 @@
 		return urlConfigs;
 	}
 
+    // N.B. Since the tags are extracted from an HTML Form, any values must already have been encoded
 	private static boolean recurseForm(Node tempNode, LinkedList urlConfigs, URL context, String selectName,
 			boolean inForm) {
 		NamedNodeMap nodeAtts = tempNode.getAttributes();
@@ -234,10 +235,10 @@
 						inForm = false;
 					}
 				} else if (tag.equalsIgnoreCase("input")) {
-					url.addArgument(getAttributeValue(nodeAtts, "name"), getAttributeValue(nodeAtts, "value"));
+					url.addEncodedArgument(getAttributeValue(nodeAtts, "name"), getAttributeValue(nodeAtts, "value"));
 				} else if (tag.equalsIgnoreCase("textarea")) {
 					try {
-						url.addArgument(getAttributeValue(nodeAtts, "name"), tempNode.getFirstChild().getNodeValue());
+						url.addEncodedArgument(getAttributeValue(nodeAtts, "name"), tempNode.getFirstChild().getNodeValue());
 					} catch (NullPointerException e) {
 						url.addArgument(getAttributeValue(nodeAtts, "name"), "");
 					}
@@ -252,7 +253,7 @@
 							value = "";
 						}
 					}
-					url.addArgument(selectName, value);
+					url.addEncodedArgument(selectName, value);
 				}
 			} else if (tag.equalsIgnoreCase("form")) {
 				try {



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org