You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/25 06:14:10 UTC
[GitHub] [spark] luluorta commented on a change in pull request #30289: [SPARK-33141][SQL] Capture SQL configs when creating permanent views
luluorta commented on a change in pull request #30289:
URL: https://github.com/apache/spark/pull/30289#discussion_r530129632
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -132,9 +132,11 @@ object AnalysisContext {
*/
class Analyzer(
override val catalogManager: CatalogManager,
- conf: SQLConf)
+ deprecatedConf: SQLConf)
Review comment:
This change is related to another sub-task of [SPARK-33138](https://issues.apache.org/jira/browse/SPARK-33138) which makes internal classes of SparkSession always using active SQLConf. I opened a seperated PR (https://github.com/apache/spark/pull/30299) and removed this change here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org