You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2023/01/12 10:24:26 UTC

[GitHub] [celix] pnoltes commented on a diff in pull request #467: Fix several null pointer dereferences and uninitialized variables issues

pnoltes commented on code in PR #467:
URL: https://github.com/apache/celix/pull/467#discussion_r1067947676


##########
bundles/pubsub/pubsub_protocol/pubsub_protocol_wire_v1/gtest/src/PS_WP_tests.cc:
##########
@@ -234,6 +234,7 @@ TEST_F(WireProtocolV1Test, WireProtocolV1Test_DecodeMetadata_Test) { // NOLINT(c
     memcpy(exp + 4, "1:a,1:b,", 8);
 
     pubsub_protocol_message_t message;
+    message.header.convertEndianess = false;

Review Comment:
   I will correct this as bug fix, but note that this does change the interfaces (SPI) header.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org