[jira] [Commented] (KAFKA-5204) Connect needs to validate Connector type during instantiation

["Dong Lin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635607#comment-16635607 ] 

Dong Lin commented on KAFKA-5204:
---------------------------------

Moving this to 2.2.0 since PR is not ready yet.

> Connect needs to validate Connector type during instantiation
> -------------------------------------------------------------
>
>                 Key: KAFKA-5204
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5204
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 0.10.2.0
>            Reporter: Konstantine Karantasis
>            Assignee: Konstantine Karantasis
>            Priority: Major
>             Fix For: 2.2.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently Connect will accept to instantiate connectors that extend the {{Connector}} abstract class but not one of its subclasses, {{SourceConnector}} or {{SinkConnector}}. 
> However, in distributed mode as well as in REST, Connect assumes in a few places that there are only two types of connectors, sinks or sources. Based on this assumption it checks the type dynamically, and if it is not a sink it treats it as a source (by constructing the corresponding configs). 
> A connector that implements only the {{Connector}} abstract class does not fit into this classification. Therefore a validation needs to take place early, during the instantiation of the {{Connector}} object. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)