[jira] [Commented] (HBASE-2645) HLog writer can do 1-2 sync operations after lease has been recovered for split process.

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489030#comment-13489030 ] 

stack commented on HBASE-2645:
------------------------------

[~ted_yu], your repeat of info in here, info that is public and available to all is of no help; its just spam in our mailboxes.  Neither is your cut-off paste of a failure on your local machine w/ no context such as what your local machine is, if it fails always, etc.  I committed the patch because it passed locally on repeated runs and passed hadoopqa.
                
> HLog writer can do 1-2 sync operations after lease has been recovered for split process.
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-2645
>                 URL: https://issues.apache.org/jira/browse/HBASE-2645
>             Project: HBase
>          Issue Type: Bug
>          Components: Filters
>    Affects Versions: 0.90.4
>            Reporter: Cosmin Lehene
>            Assignee: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 2645.txt, 2645v2.txt, 2645v3.txt, org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit-output.txt
>
>
> TestHLogSplit.testLogCannotBeWrittenOnceParsed is failing. 
> This test starts a thread that writes one edit to the log, syncs and counts. During this, a HLog.splitLog operation is started. splitLog recovers the log lease before reading the log, so that the original regionserver could not wake up and write after the split process started.  
> The test compares the number of edits reported by the split process and by the writer thread. Writer thread (called zombie in the test) should report <=  than the splitLog (sync() might raise after the last edit gets written and the edit won't get counted by zombie thread). However it appears that the zombie counts 1-2 more edits. So it looks like it can sync without a lease.
> This might be a hdfs-0.20 related issue. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira