You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/05/23 21:33:03 UTC
[GitHub] [netbeans] KacerCZ opened a new pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
KacerCZ opened a new pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155
Fixes resizing of test file selection when navigating to test file.
Files are sorted by path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155#issuecomment-634315640
@tmysik No. NetBeans 12.0 has not been released yet. I'll let you know when we can do that :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 merged pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
Posted by GitBox <gi...@apache.org>.
junichi11 merged pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155#issuecomment-633549129
@KacerCZ Please attach screenshots(before and after) if possible. Thanks for your contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155#issuecomment-633215878
@junichi11 @tmysik Please review.
Failed build seems to be unrelated to changes in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155#issuecomment-634293710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155#issuecomment-633516941
@KacerCZ
Thanks for the PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ edited a comment on pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
Posted by GitBox <gi...@apache.org>.
KacerCZ edited a comment on pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155#issuecomment-633215878
@junichi11 @tmysik Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155#issuecomment-633659521
@junichi11 I added screenshots to first comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155#discussion_r429874975
##########
File path: php/php.project/src/org/netbeans/modules/php/project/ui/actions/tests/GoToTest.java
##########
@@ -54,6 +55,14 @@
private static final Logger LOGGER = Logger.getLogger(GoToTest.class.getName());
private static final RequestProcessor RP = new RequestProcessor(GoToTest.class.getName(), 2);
+ private static class FileObjectComparator implements Comparator<FileObject> {
Review comment:
Just a note: I usually put the inner classes at the very end of the class (usually below `//~ Inner classes` comment). No need to change it in this PR, I just think it makes the code more readable (main class and then inner classes, not mixed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2155: [NETBEANS-4368] Fix test file navigation dialog
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155#issuecomment-633515464
Relevant [NetBeans issue here](https://issues.apache.org/jira/browse/NETBEANS-4368).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists