You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@atlas.apache.org by pp...@apache.org on 2024/05/06 18:47:28 UTC

(atlas) branch branch-2.0 updated: ATLAS-4860: UI: If deleted entity has long name, propertytab in UI is misaligned

This is an automated email from the ASF dual-hosted git repository.

ppawar pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/atlas.git


The following commit(s) were added to refs/heads/branch-2.0 by this push:
     new 7541afa2f ATLAS-4860: UI: If deleted entity has long name, propertytab in UI is misaligned
7541afa2f is described below

commit 7541afa2f3fea0c8242db07ca9091e14ef060952
Author: Brijesh Bhalala <br...@gmail.com>
AuthorDate: Fri May 3 15:22:00 2024 +0530

    ATLAS-4860: UI: If deleted entity has long name, propertytab in UI is misaligned
    
    Signed-off-by: Prasad Pawar <pr...@cloudera.com>
---
 dashboardv2/public/css/scss/theme.scss            | 4 ++++
 dashboardv2/public/js/utils/CommonViewFunction.js | 4 ++--
 dashboardv3/public/css/scss/theme.scss            | 4 ++++
 dashboardv3/public/js/utils/CommonViewFunction.js | 4 ++--
 4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/dashboardv2/public/css/scss/theme.scss b/dashboardv2/public/css/scss/theme.scss
index 4838ca3af..46abb127a 100644
--- a/dashboardv2/public/css/scss/theme.scss
+++ b/dashboardv2/public/css/scss/theme.scss
@@ -660,4 +660,8 @@ hr[size="10"] {
         margin-top: 5px;
         margin-left: 20px;
     }
+}
+
+.whitespace-normal {
+    white-space: normal !important;
 }
\ No newline at end of file
diff --git a/dashboardv2/public/js/utils/CommonViewFunction.js b/dashboardv2/public/js/utils/CommonViewFunction.js
index ff05ed75b..e5a75674a 100644
--- a/dashboardv2/public/js/utils/CommonViewFunction.js
+++ b/dashboardv2/public/js/utils/CommonViewFunction.js
@@ -155,7 +155,7 @@ define(['require', 'utils/Utils', 'modules/Modal', 'utils/Messages', 'utils/Enum
                             scope.$('td div[data-id="' + id + '"]').html('<a href="#!/detailPage/' + id + '">' + _.escape(id) + '</a>');
                         }
                         if (deleteButton.length) {
-                            scope.$('td div[data-id="' + id + '"]').addClass('block readOnlyLink');
+                            scope.$('td div[data-id="' + id + '"]').addClass('block whitespace-normal readOnlyLink');
                             scope.$('td div[data-id="' + id + '"]').append(deleteButton);
                         }
                     },
@@ -248,7 +248,7 @@ define(['require', 'utils/Utils', 'modules/Modal', 'utils/Messages', 'utils/Enum
                     if (readOnly) {
                         if (!fetch) {
                             tempLink += '<button title="Deleted" class="btn btn-action btn-md deleteBtn"><i class="fa fa-trash"></i></button>';
-                            subLink += '<div class="block readOnlyLink">' + tempLink + '</div>';
+                            subLink += '<div class="block whitespace-normal readOnlyLink">' + tempLink + '</div>';
                         } else {
                             fetch = false;
                             subLink += tempLink;
diff --git a/dashboardv3/public/css/scss/theme.scss b/dashboardv3/public/css/scss/theme.scss
index af9c23d9c..d5920083e 100644
--- a/dashboardv3/public/css/scss/theme.scss
+++ b/dashboardv3/public/css/scss/theme.scss
@@ -764,4 +764,8 @@ hr[size="10"] {
 .help-btn {
     cursor: pointer;
     font-size: 20px;
+}
+
+.whitespace-normal {
+    white-space: normal !important;
 }
\ No newline at end of file
diff --git a/dashboardv3/public/js/utils/CommonViewFunction.js b/dashboardv3/public/js/utils/CommonViewFunction.js
index aa1821742..c0eb7d7e7 100644
--- a/dashboardv3/public/js/utils/CommonViewFunction.js
+++ b/dashboardv3/public/js/utils/CommonViewFunction.js
@@ -155,7 +155,7 @@ define(['require', 'utils/Utils', 'modules/Modal', 'utils/Messages', 'utils/Enum
                             scope.$('td div[data-id="' + id + '"]').html('<a href="#!/detailPage/' + id + '">' + _.escape(id) + '</a>');
                         }
                         if (deleteButton.length) {
-                            scope.$('td div[data-id="' + id + '"]').addClass('block readOnlyLink');
+                            scope.$('td div[data-id="' + id + '"]').addClass('block whitespace-normal readOnlyLink');
                             scope.$('td div[data-id="' + id + '"]').append(deleteButton);
                         }
                     },
@@ -248,7 +248,7 @@ define(['require', 'utils/Utils', 'modules/Modal', 'utils/Messages', 'utils/Enum
                     if (readOnly) {
                         if (!fetch) {
                             tempLink += '<button title="Deleted" class="btn btn-action btn-md deleteBtn"><i class="fa fa-trash"></i></button>';
-                            subLink += '<div class="block readOnlyLink">' + tempLink + '</div>';
+                            subLink += '<div class="block whitespace-normal readOnlyLink">' + tempLink + '</div>';
                         } else {
                             fetch = false;
                             subLink += tempLink;