You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Naofumi Fukue (JIRA)" <ji...@apache.org> on 2012/12/11 14:55:21 UTC

[jira] [Created] (OFBIZ-5098) javascript error in hidden form

Naofumi Fukue created OFBIZ-5098:
------------------------------------

             Summary: javascript error in hidden form
                 Key: OFBIZ-5098
                 URL: https://issues.apache.org/jira/browse/OFBIZ-5098
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release 10.04, SVN trunk
            Reporter: Naofumi Fukue
            Priority: Minor


HtmlMenuRenderer generates like bellow form tags. It generates double target="_BLANK" , then cause javascript error.

  <li><form method="post" action="/ar/control/invoice.pdf" target="_BLANK" name="InvoiceSubTabBar_pdf_LF_8"><input name="invoiceId" value="8010" type="hidden"/></form><a target="_BLANK" href="javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()">PDF</a></li>
 
document.InvoiceSubTabBar_pdf_LF_8 is undefined @ javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()


Index: framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java
===================================================================
--- framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java	(revision 1419381)
+++ framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java	(working copy)
@@ -455,10 +455,12 @@
                 writer.append(name);
                 writer.append("\"");
             }
-            if (UtilValidate.isNotEmpty(targetWindow)) {
-                writer.append(" target=\"");
-                writer.append(targetWindow);
-                writer.append("\"");
+            if (!"hidden-form".equals(linkType)) {
+                if (UtilValidate.isNotEmpty(targetWindow)) {
+                    writer.append(" target=\"");
+                    writer.append(targetWindow);
+                    writer.append("\"");
+                }
             }
 
             writer.append(" href=\"");



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira