You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/07 12:30:51 UTC

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18621: [FLINK-25932][table-planner] Add deterministic uid to every Transformation created by StreamExecNode

slinkydeveloper commented on a change in pull request #18621:
URL: https://github.com/apache/flink/pull/18621#discussion_r800607856



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeBase.java
##########
@@ -157,6 +158,10 @@ protected boolean inputsContainSingleton() {
                                                 == InputProperty.DistributionType.SINGLETON);
     }
 
+    public String getOperatorUid(String operatorName) {

Review comment:
       I rather prefer to rename all of these as `create`, because even `getOperatorName` is actually generating the name, rather than "getting it"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org