You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/09/23 11:35:12 UTC

[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao commented on a change in pull request #192: [YUNIKORN-420]Add TaskGroup field in app-CRD

HuangTing-Yao commented on a change in pull request #192:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/192#discussion_r493481585



##########
File path: deployments/yunikorn-application/sample-yunikorn-app.yaml
##########
@@ -20,5 +20,19 @@ kind: Application
 metadata:
   name: example
 spec:
+  appId: "app0001"

Review comment:
       Or we should move `AppID` from spec field to status field ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org