You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by lh...@apache.org on 2024/01/18 17:28:14 UTC
(pulsar-helm-chart) branch master updated: Require helm version 3.10 or newer (#436)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new e058aa5 Require helm version 3.10 or newer (#436)
e058aa5 is described below
commit e058aa581d880df74d0f3552916b313ceb58baae
Author: Lari Hotari <lh...@users.noreply.github.com>
AuthorDate: Thu Jan 18 09:28:09 2024 -0800
Require helm version 3.10 or newer (#436)
* Add check for required helm version
* Add test scenario for helm 3.10.0
---
.github/workflows/pulsar-helm-chart-ci.yaml | 12 +++++++++++-
charts/pulsar/templates/check_helm_version.yaml | 22 ++++++++++++++++++++++
2 files changed, 33 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/pulsar-helm-chart-ci.yaml b/.github/workflows/pulsar-helm-chart-ci.yaml
index bd1a281..8f7fba7 100644
--- a/.github/workflows/pulsar-helm-chart-ci.yaml
+++ b/.github/workflows/pulsar-helm-chart-ci.yaml
@@ -199,9 +199,19 @@ jobs:
values_file: .ci/clusters/values-psp.yaml
shortname: psp
type: upgrade
+ - k8sVersion:
+ version: "1.21.14"
+ kind_image_tag: v1.21.14@sha256:8a4e9bb3f415d2bb81629ce33ef9c76ba514c14d707f9797a01e3216376ba093
+ testScenario:
+ name: "TLS with helm 3.10.0"
+ values_file: .ci/clusters/values-tls.yaml
+ shortname: tls
+ type: install
+ helmVersion: 3.10.0
env:
k8sVersion: ${{ matrix.k8sVersion.kind_image_tag }}
KUBECTL_VERSION: ${{ matrix.k8sVersion.version }}
+ HELM_VERSION: ${{ matrix.helmVersion || '3.12.3' }}
steps:
- name: checkout
uses: actions/checkout@v4
@@ -252,7 +262,7 @@ jobs:
with:
limit-access-to-actor: true
- - name: Run chart-testing (${{ matrix.testScenario.type || 'install' }})
+ - name: Run chart-testing (${{ matrix.testScenario.type || 'install' }}) with helm ${{ env.HELM_VERSION }}
run: |
case "${{ matrix.testScenario.shortname }}" in
"jwt-symmetric")
diff --git a/charts/pulsar/templates/check_helm_version.yaml b/charts/pulsar/templates/check_helm_version.yaml
new file mode 100644
index 0000000..1904745
--- /dev/null
+++ b/charts/pulsar/templates/check_helm_version.yaml
@@ -0,0 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+{{- if semverCompare "<3.10.0-0" .Capabilities.HelmVersion.Version -}}
+{{- fail "Your Helm version is not supported. Please upgrade to Helm 3.10.0 or later. The recommended version is currently 3.12.3 or newer. You can find more about Helm releases and installation at https://github.com/helm/helm/releases. " -}}
+{{- end -}}
\ No newline at end of file