You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/10/04 19:27:50 UTC
[jira] [Created] (BOOKKEEPER-418) Store hostname of locker in
replication lock
Ivan Kelly created BOOKKEEPER-418:
-------------------------------------
Summary: Store hostname of locker in replication lock
Key: BOOKKEEPER-418
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-418
Project: Bookkeeper
Issue Type: Sub-task
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.2.0
This is a debugging shortcut. If a ledger isn't being processed for a long time, this allows us to find which host is trying to rereplicate, and go look at the logs there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-418) Store hostname of locker in
replication lock
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470182#comment-13470182 ]
Ivan Kelly commented on BOOKKEEPER-418:
---------------------------------------
Yes, I was surprised we didn't have it already as I remember discussing it before. I think ip address is a better thing to store though, as it removes one lookup from the debugging process. Both these things (locks and auditor votes) should be protobuf structures for future compatibility.
> Store hostname of locker in replication lock
> --------------------------------------------
>
> Key: BOOKKEEPER-418
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-418
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
>
> This is a debugging shortcut. If a ledger isn't being processed for a long time, this allows us to find which host is trying to rereplicate, and go look at the logs there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-418) Store hostname of locker in
replication lock
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472271#comment-13472271 ]
Rakesh R commented on BOOKKEEPER-418:
-------------------------------------
+1. I was thinking about Auditor part. Anyway you have created separate jira BOOKKEEPER-426 for this:-)
> Store hostname of locker in replication lock
> --------------------------------------------
>
> Key: BOOKKEEPER-418
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-418
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-418.diff
>
>
> This is a debugging shortcut. If a ledger isn't being processed for a long time, this allows us to find which host is trying to rereplicate, and go look at the logs there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-418) Store hostname of locker in
replication lock
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471702#comment-13471702 ]
Uma Maheswara Rao G commented on BOOKKEEPER-418:
------------------------------------------------
I have looked at the patch. Patch looks good to me.
Generally in real clusters this would be fine. If we want to debug any issue in Jenkins/CI then this information may not help as all will in same host.
But I also don't see any clean way to include port.
+1
> Store hostname of locker in replication lock
> --------------------------------------------
>
> Key: BOOKKEEPER-418
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-418
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-418.diff
>
>
> This is a debugging shortcut. If a ledger isn't being processed for a long time, this allows us to find which host is trying to rereplicate, and go look at the logs there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-418) Store hostname of locker in
replication lock
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470013#comment-13470013 ]
Rakesh R commented on BOOKKEEPER-418:
-------------------------------------
Thanks for identifying, will be very useful.
Auditor has similar stuff, here its using bookieId.
{code}
// update the auditor bookie id in the election path. This is
// done for debugging purpose
zkc.setData(getVotePath(""), bookieId.getBytes(), -1);
{code}
> Store hostname of locker in replication lock
> --------------------------------------------
>
> Key: BOOKKEEPER-418
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-418
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
>
> This is a debugging shortcut. If a ledger isn't being processed for a long time, this allows us to find which host is trying to rereplicate, and go look at the logs there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-418) Store hostname of locker in
replication lock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473437#comment-13473437 ]
Hudson commented on BOOKKEEPER-418:
-----------------------------------
Integrated in bookkeeper-trunk #748 (See [https://builds.apache.org/job/bookkeeper-trunk/748/])
BOOKKEEPER-418: Store hostname of locker in replication lock (ivank) (Revision 1396536)
Result = SUCCESS
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerUnderreplicationManager.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/DataFormats.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/proto/DataFormats.proto
> Store hostname of locker in replication lock
> --------------------------------------------
>
> Key: BOOKKEEPER-418
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-418
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-418.diff
>
>
> This is a debugging shortcut. If a ledger isn't being processed for a long time, this allows us to find which host is trying to rereplicate, and go look at the logs there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-418) Store hostname of locker in
replication lock
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470191#comment-13470191 ]
Uma Maheswara Rao G commented on BOOKKEEPER-418:
------------------------------------------------
We discussed it while we are implementing CurrentInprogress in BKJM. Somehow we missed it here.
> Store hostname of locker in replication lock
> --------------------------------------------
>
> Key: BOOKKEEPER-418
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-418
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
>
> This is a debugging shortcut. If a ledger isn't being processed for a long time, this allows us to find which host is trying to rereplicate, and go look at the logs there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-418) Store hostname of locker in
replication lock
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-418:
----------------------------------
Attachment: BOOKKEEPER-418.diff
Added LockInfo to node. Can't put port in there as it's not available. Class can only be configured with an AbstractConfiguration, not a ServerConfiguration.
> Store hostname of locker in replication lock
> --------------------------------------------
>
> Key: BOOKKEEPER-418
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-418
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-418.diff
>
>
> This is a debugging shortcut. If a ledger isn't being processed for a long time, this allows us to find which host is trying to rereplicate, and go look at the logs there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira