You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Marshall Schor (JIRA)" <de...@uima.apache.org> on 2014/11/20 21:49:33 UTC
[jira] [Updated] (UIMA-4099) check for addFS with wrong Sofa misses
many paths
[ https://issues.apache.org/jira/browse/UIMA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marshall Schor updated UIMA-4099:
---------------------------------
Description:
The docs say that subtypes of AnnotationBase can only be added to indices in the CAS View associated with the Sofa for that Feature Structure (see http://uima.apache.org/d/uimaj-2.6.0/tutorials_and_users_guides.html#ugr.tug.aas.annotations_associated_sofa )
A check was put in to enforce this, in the casImpl code, when calling aCasView.addFsToIndexes. Unfortunately, this check misses checking the many other paths that are used to add a FS to an index. For instance, the path when using JCas: instance.addToIndexes(), and many others.
Fix this by moving the test downwards to the place where all code paths flow together.
Allow restoring the old behavior in case needed, via a JVM -D parameter: uima.disable_enhanced_check_wrong_add_to_index
was:
The docs say that subtypes of AnnotationBase can only be added to indices in the CAS View associated with the Sofa for that Feature Structure (see http://uima.apache.org/d/uimaj-2.6.0/tutorials_and_users_guides.html#ugr.tug.aas.annotations_associated_sofa )
A check was put in to enforce this, in the casImpl code, when calling aCasView.addFsToIndexes. Unfortunately, this check misses checking the many other paths that are used to add a FS to an index. For instance, the path when using JCas: instance.addToIndexes(), and many others.
Fix this by moving the test downwards to the place where all code paths flow together.
> check for addFS with wrong Sofa misses many paths
> -------------------------------------------------
>
> Key: UIMA-4099
> URL: https://issues.apache.org/jira/browse/UIMA-4099
> Project: UIMA
> Issue Type: Bug
> Components: Core Java Framework
> Affects Versions: 2.6.0SDK
> Reporter: Marshall Schor
> Assignee: Marshall Schor
> Priority: Minor
> Fix For: 2.7.0SDK
>
>
> The docs say that subtypes of AnnotationBase can only be added to indices in the CAS View associated with the Sofa for that Feature Structure (see http://uima.apache.org/d/uimaj-2.6.0/tutorials_and_users_guides.html#ugr.tug.aas.annotations_associated_sofa )
> A check was put in to enforce this, in the casImpl code, when calling aCasView.addFsToIndexes. Unfortunately, this check misses checking the many other paths that are used to add a FS to an index. For instance, the path when using JCas: instance.addToIndexes(), and many others.
> Fix this by moving the test downwards to the place where all code paths flow together.
> Allow restoring the old behavior in case needed, via a JVM -D parameter: uima.disable_enhanced_check_wrong_add_to_index
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)