You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "beiwei30 (GitHub)" <gi...@apache.org> on 2018/12/10 08:55:48 UTC

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2803: Fix telnet can not find method with enum type

I think it is not necessary to call `CompatibleTypeUtils.compatibleTypeConvert(arg, type`, this logic can be simplified as below, since we know arg is always a String type in this case.

```java
            if (ReflectUtils.isPrimitive(arg.getClass())) {
                if (!ReflectUtils.isPrimitive(type) && !type.isEnum()) {
                    return false;
                }
            }
```

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2803 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org