Re: [PR] Test for reading read statistics from parquet files without statistics and boolean & struct data type [datafusion]

["NGA-TRAN (via GitHub)" <gi...@apache.org>]

NGA-TRAN commented on code in PR #10608:
URL: https://github.com/apache/datafusion/pull/10608#discussion_r1608970404


##########
datafusion/core/tests/parquet/arrow_statistics.rs:
##########
@@ -73,6 +73,22 @@ pub fn parquet_file_one_column(
     no_null_values_start: i64,
     no_null_values_end: i64,
     row_per_group: usize,
+) -> ParquetRecordBatchReaderBuilder<File> {
+    parquet_file_one_column_stats(
+        num_null,
+        no_null_values_start,
+        no_null_values_end,
+        row_per_group,
+        EnabledStatistics::Chunk,
+    )
+}
+
+pub fn parquet_file_one_column_stats(

Review Comment:
   If we want to do this, we need to think about `parquet_file_many_columns`, too.
   I have to sign off now. How about we do this in following PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org