[GitHub] [rocketmq] zhouxinyu commented on a diff in pull request #6288: [ISSUE #6287] Fixed two redundant judgments

["zhouxinyu (via GitHub)" <gi...@apache.org>]

zhouxinyu commented on code in PR #6288:
URL: https://github.com/apache/rocketmq/pull/6288#discussion_r1131914244


##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/common/GrpcConverter.java:
##########
@@ -143,9 +143,8 @@ protected SystemProperties buildSystemProperties(MessageExt messageExt) {
         if (uniqKey == null) {
             uniqKey = messageExt.getMsgId();
         }
-        if (uniqKey != null) {
-            systemPropertiesBuilder.setMessageId(uniqKey);
-        }
+
+        systemPropertiesBuilder.setMessageId(uniqKey);

Review Comment:
   It is also possible to return null for messageExt.getMsgId()?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org