You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/03 05:32:35 UTC
[GitHub] [incubator-nuttx-apps] anchao opened a new pull request #159:
wireless/wapi: add save_config/reconnect/scan_results support
anchao opened a new pull request #159: wireless/wapi: add save_config/reconnect/scan_results support
URL: https://github.com/apache/incubator-nuttx-apps/pull/159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request
#159: wireless/wapi: add save_config/reconnect/scan_results support
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #159: wireless/wapi: add save_config/reconnect/scan_results support
URL: https://github.com/apache/incubator-nuttx-apps/pull/159#discussion_r402948765
##########
File path: netutils/netinit/netinit_associate.c
##########
@@ -60,7 +60,7 @@
int netinit_associate(FAR const char *ifname)
{
struct wpa_wconfig_s conf;
- int ret;
+ int ret = -EINVAL;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #159:
wireless/wapi: add save_config/reconnect/scan_results support
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #159: wireless/wapi: add save_config/reconnect/scan_results support
URL: https://github.com/apache/incubator-nuttx-apps/pull/159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request
#159: wireless/wapi: add save_config/reconnect/scan_results support
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #159: wireless/wapi: add save_config/reconnect/scan_results support
URL: https://github.com/apache/incubator-nuttx-apps/pull/159#discussion_r402918924
##########
File path: netutils/netinit/netinit_associate.c
##########
@@ -60,7 +60,7 @@
int netinit_associate(FAR const char *ifname)
{
struct wpa_wconfig_s conf;
- int ret;
+ int ret = -EINVAL;
Review comment:
This is causing the build to fail. errno.h is not included.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request
#159: wireless/wapi: add save_config/reconnect/scan_results support
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #159: wireless/wapi: add save_config/reconnect/scan_results support
URL: https://github.com/apache/incubator-nuttx-apps/pull/159#discussion_r402917488
##########
File path: netutils/netinit/netinit_associate.c
##########
@@ -77,7 +77,8 @@ int netinit_associate(FAR const char *ifname)
conf.phraselen = strlen(conf.passphrase);
}
- ret = wpa_driver_wext_associate(&conf);
+ if (conf.ssidlen > 0)
+ ret = wpa_driver_wext_associate(&conf);
Review comment:
```suggestion
if (conf.ssidlen > 0)
{
ret = wpa_driver_wext_associate(&conf);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request
#159: wireless/wapi: add save_config/reconnect/scan_results support
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #159: wireless/wapi: add save_config/reconnect/scan_results support
URL: https://github.com/apache/incubator-nuttx-apps/pull/159#discussion_r402948739
##########
File path: netutils/netinit/netinit_associate.c
##########
@@ -77,7 +77,8 @@ int netinit_associate(FAR const char *ifname)
conf.phraselen = strlen(conf.passphrase);
}
- ret = wpa_driver_wext_associate(&conf);
+ if (conf.ssidlen > 0)
+ ret = wpa_driver_wext_associate(&conf);
Review comment:
Oops, Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] anchao commented on issue #159:
wireless/wapi: add save_config/reconnect/scan_results support
Posted by GitBox <gi...@apache.org>.
anchao commented on issue #159: wireless/wapi: add save_config/reconnect/scan_results support
URL: https://github.com/apache/incubator-nuttx-apps/pull/159#issuecomment-608247757
so, i think we can ignore the warning here like:
...
wireless/wapi/src/util.c:79:6: error: Mixed case identifier found
wireless/wapi/src/util.c:106:9: error: Mixed case identifier found
wireless/wapi/src/util.c:122:33: error: Mixed case identifier found
wireless/wapi/src/util.c:128:6: error: Mixed case identifier found
...
since the cJson api is mixed case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services