You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/01 11:37:34 UTC

[GitHub] [incubator-nuttx] zhhyu7 opened a new pull request #5945: fix:Remove udp send large pkt assert

zhhyu7 opened a new pull request #5945:
URL: https://github.com/apache/incubator-nuttx/pull/5945


   Signed-off-by: zhanghongyu <zh...@xiaomi.com>
   
   ## Summary
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5945: fix:Remove udp send large pkt assert

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5945:
URL: https://github.com/apache/incubator-nuttx/pull/5945


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5945: fix:Remove udp send large pkt assert

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5945:
URL: https://github.com/apache/incubator-nuttx/pull/5945#discussion_r840509385



##########
File path: net/devif/devif_iobsend.c
##########
@@ -55,7 +55,11 @@
 void devif_iob_send(FAR struct net_driver_s *dev, FAR struct iob_s *iob,
                     unsigned int len, unsigned int offset)
 {
-  DEBUGASSERT(dev && len > 0 && len < NETDEV_PKTSIZE(dev));
+  if (!(dev && len > 0 && len < NETDEV_PKTSIZE(dev)))

Review comment:
       ```suggestion
     if (dev == NULL || len == 0 || len >= NETDEV_PKTSIZE(dev)))
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org