You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2009/06/01 10:28:07 UTC
[jira] Created: (HBASE-1466) Binary keys are not first class
citizens
Binary keys are not first class citizens
----------------------------------------
Key: HBASE-1466
URL: https://issues.apache.org/jira/browse/HBASE-1466
Project: Hadoop HBase
Issue Type: Bug
Affects Versions: 0.20.0
Reporter: ryan rawson
Fix For: 0.20.0
If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
- grep/less cant search in logfiles with binary data
- displays are unreadable due to weird utf8/other issues
- can't use the region historian
- etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1466) Binary keys are not first class
citizens
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1466:
-------------------------------
Attachment: HBASE-1466-v2.patch
v2 of patch that builds against trunk.
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1466-v2.patch, HBASE-1466.patch, ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HBASE-1466) Binary keys are not first class
citizens
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson reopened HBASE-1466:
--------------------------------
this never got applied to trunk...
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1466) Binary keys are not first class
citizens
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1466:
-------------------------------
Attachment: (was: HBASE-1466-supp.patch)
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1466-v2.patch, HBASE-1466.patch, ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-1466) Binary keys are not first class
citizens
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson reassigned HBASE-1466:
----------------------------------
Assignee: ryan rawson
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1466) Binary keys are not first class
citizens
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1466:
-------------------------------
Attachment: HBASE-1466-supp.patch
supplemental patch to fix build problem. layer on after the previous patch.
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1466-supp.patch, HBASE-1466.patch, ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1466) Binary keys are not first class
citizens
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1466:
-------------------------------
Attachment: HBASE-1466-v2.patch
updated patch that builds against trunk.
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1466-v2.patch, HBASE-1466.patch, ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1466) Binary keys are not first class
citizens
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1466:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed with following differences:
+ Moved HFileStats#main to HFile. Thats where I think folks will go to look for it.
+ Did not commit the bloom filter implementations. Seemed odd that this patch was removing bloom filters from core then adding implementations to util. I pasted the implemetnations to a patch up in hbase-1200
+ I commented out bits of the new murmurhash test because they are failing.... maybe you can check it out: HBASE-
This patch seems to add a lot of logging but we can turn that down later.
Ryan, does this patch resolve HBASE-1131? HBASE-1363?
Thanks for the sweet patch Ryan.
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1466) Binary keys are not first class
citizens
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1466:
-------------------------------
Attachment: ryan-uber.patch
this also fixes HBASE-1467, HBASE-1468
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1466) Binary keys are not first class
citizens
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1466:
-------------------------------
Attachment: HBASE-1466.patch
a revised patch that does 2 things:
- removes bloom filter flags from HFile
- enables binary key pretty printing.
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1466.patch, ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1466) Binary keys are not first class
citizens
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1466.
--------------------------
Resolution: Fixed
Looks like Ryan committed this -- resolving.
{code}
Author: rawson
Date: Sat Jun 6 22:07:20 2009
New Revision: 782314
URL: http://svn.apache.org/viewvc?rev=782314&view=rev
Log:
HBASE-1466, binary keys now are pretty-printed, removed HFile bloom filter flag
...
{code}
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1466-v2.patch, HBASE-1466.patch, ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1466) Binary keys are not first class
citizens
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715126#action_12715126 ]
stack commented on HBASE-1466:
------------------------------
HBASE-1469 is the murmur hash issue.
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1466) Binary keys are not first class
citizens
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716925#action_12716925 ]
Jonathan Gray commented on HBASE-1466:
--------------------------------------
Applied v2 patch to trunk. All tests I ran passed. +1 on commit.
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1466-v2.patch, HBASE-1466.patch, ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1466) Binary keys are not first class
citizens
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717114#action_12717114 ]
stack commented on HBASE-1466:
------------------------------
Sorry for bungling this one. Thought I'd applied it.
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1466-v2.patch, HBASE-1466.patch, ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1466) Binary keys are not first class
citizens
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1466:
-------------------------------
Attachment: (was: HBASE-1466-v2.patch)
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1466-v2.patch, HBASE-1466.patch, ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1466) Binary keys are not first class
citizens
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1466:
-------------------------------
Status: Patch Available (was: Open)
> Binary keys are not first class citizens
> ----------------------------------------
>
> Key: HBASE-1466
> URL: https://issues.apache.org/jira/browse/HBASE-1466
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: ryan-uber.patch
>
>
> If you use binary keys, you don't get full features as if you were not using binary keys. Some things that are broken:
> - grep/less cant search in logfiles with binary data
> - displays are unreadable due to weird utf8/other issues
> - can't use the region historian
> - etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.