[GitHub] [beam] damccorm commented on a diff in pull request #17374: [BEAM-11105] Stateful watermark estimation

[GitBox <gi...@apache.org>]

damccorm commented on code in PR #17374:
URL: https://github.com/apache/beam/pull/17374#discussion_r850722773


##########
sdks/go/pkg/beam/pardo.go:
##########
@@ -64,9 +66,16 @@ func TryParDo(s Scope, dofn interface{}, col PCollection, opts ...Option) ([]PCo
 	}
 
 	var rc *coder.Coder
+	// Sdfs will always encode restrictions as KV<restriction, watermark state | nil>
 	if fn.IsSplittable() {
 		sdf := (*graph.SplittableDoFn)(fn)
-		rc, err = inferCoder(typex.New(sdf.RestrictionT()))
+		restT := typex.New(sdf.RestrictionT())
+		// If no watermark estimator state, use boolean as a placeholder

Review Comment:
   @lostluck - I'd appreciate input on this, is there an easy way to encode nil state? Using a bool here isn't a huge deal performance-wise, but its kinda odd and not really ideal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org