You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2009/08/25 16:30:04 UTC

[Bug 6185] New: add_header adds header fields in random order

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6185

           Summary: add_header adds header fields in random order
           Product: Spamassassin
           Version: 3.3.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Libraries
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: Mark.Martinec@ijs.si


The 'add_header' configuration option keeps requested header field names
in a perl hash, so when these are finally inserted into a message, their
order is seemingly random, i.e. as provided by a hash.

I think it would be nice to let the configuration order be preserved,
and header field names kept in a list instead of a hash. As the number
of such added header fields is small, I don't see any performance
concerns during configuration, and during insertion the list is traversed
linearly even now. Any objections for such a change?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6185] add_header adds header fields in random order

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6185





--- Comment #1 from Mark Martinec <Ma...@ijs.si>  2009-08-25 09:43:26 PST ---
  Bug 6185 - 'add_header' config option adds header fields in
  random order - change internal representation to preserve
  the declared order of added header fields
Sending        lib/Mail/SpamAssassin/Conf.pm
Sending        lib/Mail/SpamAssassin/PerMsgStatus.pm
Committed revision 807706 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=807706 ).

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6185] add_header adds header fields in random order

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6185


Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Mark Martinec <Ma...@ijs.si>  2009-08-26 06:00:25 PST ---
closing...

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.