You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/14 15:51:25 UTC
[GitHub] [superset] Joel-Haeberli opened a new pull request, #21083: fix(install): set SUPERSET_VERSION_RC at the right time
Joel-Haeberli opened a new pull request, #21083:
URL: https://github.com/apache/superset/pull/21083
fixes #21082
### SUMMARY
Fixes problem as described in the issue #21082
### TESTING INSTRUCTIONS
1. execute command below in a environment which doesn't contain any of the superset env variables.
```
[YOUR_SUPERSET_PATH]/RELEASING/make_tarball.sh [VERSION] [RC] [PGP_KEY_NAME]
```
2. this should run without failures.
### ADDITIONAL INFORMATION
fixes #21082
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(install): set SUPERSET_VERSION_RC at the right time [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #21083:
URL: https://github.com/apache/superset/pull/21083#issuecomment-1924327114
@Joel-Haeberli — Sorry this slipped though the cracks for so long! Thanks for reporting both the issue and opening the PR. Please feel free to tag committers here or ping us on [Superset Slack](http://bit.ly/join-superset-slack) if things get stuck like this.
@eschutho this seems like a straightforward fix to a problem I haven't encountered... curious your take :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org