[jira] [Commented] (TEZ-2828) Fix typo in "Shuffle assigned " log statement in org.apache.tez.runtime.library.common.shuffle.orderedgrouped.Shuffle

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745751#comment-14745751 ] 

TezQA commented on TEZ-2828:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12756002/TEZ-2828.1.patch
  against master revision d93bdc7.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in  

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/1141//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1141//console

This message is automatically generated.

> Fix typo in "Shuffle assigned " log statement in org.apache.tez.runtime.library.common.shuffle.orderedgrouped.Shuffle
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-2828
>                 URL: https://issues.apache.org/jira/browse/TEZ-2828
>             Project: Apache Tez
>          Issue Type: Task
>            Reporter: Johannes Zillmann
>            Priority: Trivial
>         Attachments: TEZ-2828.1.patch
>
>
> In the constructor of {{org.apache.tez.runtime.library.common.shuffle.orderedgrouped.Shuffle}} there is this log statement:
> {code}
> LOG.info("Shuffle assigned with " + numInputs + " inputs" + ", codec: "
>         + (codec == null ? "None" : codec.getClass().getName()) + 
>         "ifileReadAhead: " + ifileReadAhead);
> {code}
> {{ifileReadAhead}} is not separated from codecClass which reads confusing:
> {code}
> 2015-09-15 11:59:41,117 INFO [Initializer 1] orderedgrouped.Shuffle: Shuffle assigned with 7 inputs, codec: org.apache.hadoop.io.compress.DefaultCodecifileReadAhead: true
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)