You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/14 10:53:33 UTC
[GitHub] [iceberg] singhpk234 opened a new pull request, #5277: INFRA: Allowlist only required git properties in IcebergBuild info
singhpk234 opened a new pull request, #5277:
URL: https://github.com/apache/iceberg/pull/5277
### About the change
presently by default `gradle-git-properties` plugin add all the git properties as below :
```
git.branch
git.build.host
git.build.user.email
git.build.user.name
git.build.version
git.closest.tag.commit.count
git.closest.tag.name
git.commit.id
git.commit.id.abbrev
git.commit.id.describe
git.commit.message.full
git.commit.message.short
git.commit.time
git.commit.user.email
git.commit.user.name
git.dirty
git.remote.origin.url
git.tags
git.total.commit.count
```
[[ref](https://github.com/n0mer/gradle-git-properties)]
This includes sensitive properties like `git.build.host` & `git.remote.origin.url`.
This changes avoid exposing all props, by only exposing the properties required by Iceberg Build Info.
-----
Testing Done :
Exsiting UT.
cc @rdblue @kbendick @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on a diff in pull request #5277: Build: Exclude unnecessary git properties from iceberg-build.properties
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on code in PR #5277:
URL: https://github.com/apache/iceberg/pull/5277#discussion_r921791272
##########
build.gradle:
##########
@@ -64,6 +64,8 @@ gitProperties {
gitPropertiesResourceDir = file("${rootDir}/build")
extProperty = 'gitProps'
failOnNoGitDirectory = true
+ keys = ['git.branch', 'git.build.version', 'git.commit.id.abbrev', 'git.commit.id', 'git.commit.message.short',
+ 'git.commit.time', 'git.tags']
Review Comment:
sure added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #5277: Build: Exclude unnecessary git properties from iceberg-build.properties
Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #5277:
URL: https://github.com/apache/iceberg/pull/5277#issuecomment-1184831320
For reference, here's the class that pulls in this information at runtime at present: https://github.com/apache/iceberg/blob/90fe0edf1a671095e587a53adeb31cc84d01fb89/api/src/main/java/org/apache/iceberg/IcebergBuild.java#L63-L73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on a diff in pull request #5277: Build: Allowlist only required git properties in IcebergBuild info
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on code in PR #5277:
URL: https://github.com/apache/iceberg/pull/5277#discussion_r921094413
##########
build.gradle:
##########
@@ -64,6 +64,7 @@ gitProperties {
gitPropertiesResourceDir = file("${rootDir}/build")
extProperty = 'gitProps'
failOnNoGitDirectory = true
+ keys = ['git.commit.id.abbrev', 'git.commit.id', 'git.branch', 'git.tags', 'git.build.version']
Review Comment:
sure added, i just wanted to omit exposing the two props (git.build.host & git.remote.origin.url) hence added the change to only allow props required by us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a diff in pull request #5277: Build: Exclude unnecessary git properties from iceberg-build.properties
Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #5277:
URL: https://github.com/apache/iceberg/pull/5277#discussion_r921512140
##########
build.gradle:
##########
@@ -64,6 +64,7 @@ gitProperties {
gitPropertiesResourceDir = file("${rootDir}/build")
extProperty = 'gitProps'
failOnNoGitDirectory = true
+ keys = ['git.commit.id.abbrev', 'git.commit.id', 'git.branch', 'git.tags', 'git.build.version']
Review Comment:
+1 on omitting those two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5277: Build: Exclude unnecessary git properties from iceberg-build.properties
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5277:
URL: https://github.com/apache/iceberg/pull/5277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5277: Build: Exclude unnecessary git properties from iceberg-build.properties
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5277:
URL: https://github.com/apache/iceberg/pull/5277#issuecomment-1185658187
Thanks, @singhpk234!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a diff in pull request #5277: Build: Exclude unnecessary git properties from iceberg-build.properties
Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #5277:
URL: https://github.com/apache/iceberg/pull/5277#discussion_r921512140
##########
build.gradle:
##########
@@ -64,6 +64,7 @@ gitProperties {
gitPropertiesResourceDir = file("${rootDir}/build")
extProperty = 'gitProps'
failOnNoGitDirectory = true
+ keys = ['git.commit.id.abbrev', 'git.commit.id', 'git.branch', 'git.tags', 'git.build.version']
Review Comment:
+1 on omitting those two. It feels like it leaks a lot of personal info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5277: Build: Exclude unnecessary git properties from iceberg-build.properties
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5277:
URL: https://github.com/apache/iceberg/pull/5277#discussion_r921568262
##########
build.gradle:
##########
@@ -64,6 +64,8 @@ gitProperties {
gitPropertiesResourceDir = file("${rootDir}/build")
extProperty = 'gitProps'
failOnNoGitDirectory = true
+ keys = ['git.branch', 'git.build.version', 'git.commit.id.abbrev', 'git.commit.id', 'git.commit.message.short',
+ 'git.commit.time', 'git.tags']
Review Comment:
The nearest tag seems useful to me as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #5277: Build: Allowlist only required git properties in IcebergBuild info
Posted by GitBox <gi...@apache.org>.
nastra commented on code in PR #5277:
URL: https://github.com/apache/iceberg/pull/5277#discussion_r921032446
##########
build.gradle:
##########
@@ -64,6 +64,7 @@ gitProperties {
gitPropertiesResourceDir = file("${rootDir}/build")
extProperty = 'gitProps'
failOnNoGitDirectory = true
+ keys = ['git.commit.id.abbrev', 'git.commit.id', 'git.branch', 'git.tags', 'git.build.version']
Review Comment:
I would probably also include `git.commit.message.short / git.commit.time` as that seems useful as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org