[jira] [Commented] (YARN-3766) ATS Web UI breaks because of YARN-3467

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571867#comment-14571867 ] 

Hadoop QA commented on YARN-3766:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  16m 25s | Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 33s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 38s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 54s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 59s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   3m 12s | Tests passed in hadoop-yarn-server-applicationhistoryservice. |
| {color:green}+1{color} | yarn tests |   0m 26s | Tests passed in hadoop-yarn-server-common. |
| | |  42m 39s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12737404/YARN-3766.1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / bc85959 |
| Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/8189/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html |
| hadoop-yarn-server-applicationhistoryservice test log | https://builds.apache.org/job/PreCommit-YARN-Build/8189/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt |
| hadoop-yarn-server-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/8189/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8189/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8189/console |


This message was automatically generated.

> ATS Web UI breaks because of YARN-3467
> --------------------------------------
>
>                 Key: YARN-3766
>                 URL: https://issues.apache.org/jira/browse/YARN-3766
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, webapp, yarn
>    Affects Versions: 2.8.0
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>            Priority: Blocker
>         Attachments: ATSWebPageBreaks.png, YARN-3766.1.patch
>
>
> The ATS web UI breaks because of the following changes made in YARN-3467.
> {code}
> +++ hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/WebPageUtils.java
> @@ -52,9 +52,9 @@ private static String getAppsTableColumnDefs(
>        .append(", 'mRender': renderHadoopDate }")
>        .append("\n, {'sType':'numeric', bSearchable:false, 'aTargets':");
>      if (isFairSchedulerPage) {
> -      sb.append("[11]");
> +      sb.append("[13]");
>      } else if (isResourceManager) {
> -      sb.append("[10]");
> +      sb.append("[12]");
>      } else {
>        sb.append("[9]");
>      }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)