You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Puneet Gupta <pu...@gmail.com> on 2017/02/21 10:53:06 UTC

Review Request 56877: LENS-1392: Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56877/
-----------------------------------------------------------

Review request for lens.


Bugs: lens-1392
    https://issues.apache.org/jira/browse/lens-1392


Repository: lens


Description
-------

1. Fix for test failures in QueryAPIErrorResponseTest. 
2. Promoted JoinResolver and TimeRangeChecker above storageTableResolver CubeQueryRewriter#setupRewriters


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 4dd3d007e1629331bdffdbfc67801b3dbe573630 
  lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 02e2f8b173848f1688cfaad1ba19483d5470ceed 
  lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java 040051955a9b83e4b4fd1ebb99194b46db569924 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 567c92934fdaa58252ebe6726712dc76ac3edd0d 

Diff: https://reviews.apache.org/r/56877/diff/


Testing
-------

QueryAPIErrorResponseTest Test cases


Thanks,

Puneet Gupta


Re: Review Request 56877: LENS-1392: Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56877/#review166147
-----------------------------------------------------------


Ship it!




Ship It!

- Rajat Khandelwal


On Feb. 21, 2017, 4:23 p.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56877/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2017, 4:23 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-1392
>     https://issues.apache.org/jira/browse/lens-1392
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 1. Fix for test failures in QueryAPIErrorResponseTest. 
> 2. Promoted JoinResolver and TimeRangeChecker above storageTableResolver CubeQueryRewriter#setupRewriters
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 4dd3d007e1629331bdffdbfc67801b3dbe573630 
>   lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 02e2f8b173848f1688cfaad1ba19483d5470ceed 
>   lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java 040051955a9b83e4b4fd1ebb99194b46db569924 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 567c92934fdaa58252ebe6726712dc76ac3edd0d 
> 
> Diff: https://reviews.apache.org/r/56877/diff/
> 
> 
> Testing
> -------
> 
> QueryAPIErrorResponseTest Test cases
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>