You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2010/03/12 01:56:27 UTC
[jira] Created: (FELIX-2195) Using URLDecoder.decode on locations
is wrong
Using URLDecoder.decode on locations is wrong
---------------------------------------------
Key: FELIX-2195
URL: https://issues.apache.org/jira/browse/FELIX-2195
Project: Felix
Issue Type: Bug
Components: Framework
Affects Versions: felix-2.0.4
Reporter: David Jencks
URLDecoder is supposed to be for decoding form goo stuffed into a url, not for decoding the path component of a url. Using it for this produces wrong results. In partucular, mac os x likes to make temporary files with strings like "+++++++" in the path. When run through URLDecoder these turn into spaces which means felix can't find the file you just gave it a valid file system location for. Since equinox does this correctly we can't use felix in geronimo until this is fixed.
IIUC URLDecoder is used as an attempt to maintain compatibility with ancient vms that lack URI and its correct decoding behavior. Fortunately apache harmony implements URI so the attached patch borrows the implementation from harmony to provide correct behavior on antique vms.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2195) Using URLDecoder.decode on locations
is wrong
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844427#action_12844427 ]
Karl Pauls commented on FELIX-2195:
-----------------------------------
Thanks. Do you need a 2.0.5 release quickly for geronimo or can you stay on trunk for a while?
> Using URLDecoder.decode on locations is wrong
> ---------------------------------------------
>
> Key: FELIX-2195
> URL: https://issues.apache.org/jira/browse/FELIX-2195
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.4
> Reporter: David Jencks
> Attachments: FELIX-2195.diff
>
>
> URLDecoder is supposed to be for decoding form goo stuffed into a url, not for decoding the path component of a url. Using it for this produces wrong results. In partucular, mac os x likes to make temporary files with strings like "+++++++" in the path. When run through URLDecoder these turn into spaces which means felix can't find the file you just gave it a valid file system location for. Since equinox does this correctly we can't use felix in geronimo until this is fixed.
> IIUC URLDecoder is used as an attempt to maintain compatibility with ancient vms that lack URI and its correct decoding behavior. Fortunately apache harmony implements URI so the attached patch borrows the implementation from harmony to provide correct behavior on antique vms.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2195) Using URLDecoder.decode on locations
is wrong
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846191#action_12846191 ]
David Jencks commented on FELIX-2195:
-------------------------------------
We don't need a release that quickly, but if there's going to be a release using the old resolver I'd suggest including this fix would be a good idea. Otherwise I assume the problems with the new resolver will eventually be worked out so we can use it. Meanwhile it would be great to get whatever snapshots are available to include this code.
> Using URLDecoder.decode on locations is wrong
> ---------------------------------------------
>
> Key: FELIX-2195
> URL: https://issues.apache.org/jira/browse/FELIX-2195
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.4
> Reporter: David Jencks
> Attachments: FELIX-2195.diff
>
>
> URLDecoder is supposed to be for decoding form goo stuffed into a url, not for decoding the path component of a url. Using it for this produces wrong results. In partucular, mac os x likes to make temporary files with strings like "+++++++" in the path. When run through URLDecoder these turn into spaces which means felix can't find the file you just gave it a valid file system location for. Since equinox does this correctly we can't use felix in geronimo until this is fixed.
> IIUC URLDecoder is used as an attempt to maintain compatibility with ancient vms that lack URI and its correct decoding behavior. Fortunately apache harmony implements URI so the attached patch borrows the implementation from harmony to provide correct behavior on antique vms.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2195) Using URLDecoder.decode on locations
is wrong
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall updated FELIX-2195:
-----------------------------------
Fix Version/s: (was: felix-3.0.0)
felix-2.0.5
> Using URLDecoder.decode on locations is wrong
> ---------------------------------------------
>
> Key: FELIX-2195
> URL: https://issues.apache.org/jira/browse/FELIX-2195
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.4
> Reporter: David Jencks
> Assignee: Karl Pauls
> Fix For: felix-2.0.5
>
> Attachments: FELIX-2195.diff
>
>
> URLDecoder is supposed to be for decoding form goo stuffed into a url, not for decoding the path component of a url. Using it for this produces wrong results. In partucular, mac os x likes to make temporary files with strings like "+++++++" in the path. When run through URLDecoder these turn into spaces which means felix can't find the file you just gave it a valid file system location for. Since equinox does this correctly we can't use felix in geronimo until this is fixed.
> IIUC URLDecoder is used as an attempt to maintain compatibility with ancient vms that lack URI and its correct decoding behavior. Fortunately apache harmony implements URI so the attached patch borrows the implementation from harmony to provide correct behavior on antique vms.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-2195) Using URLDecoder.decode on locations is
wrong
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed FELIX-2195.
-------------------------------
Works great, many thanks!
> Using URLDecoder.decode on locations is wrong
> ---------------------------------------------
>
> Key: FELIX-2195
> URL: https://issues.apache.org/jira/browse/FELIX-2195
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.4
> Reporter: David Jencks
> Assignee: Karl Pauls
> Fix For: felix-3.0.0
>
> Attachments: FELIX-2195.diff
>
>
> URLDecoder is supposed to be for decoding form goo stuffed into a url, not for decoding the path component of a url. Using it for this produces wrong results. In partucular, mac os x likes to make temporary files with strings like "+++++++" in the path. When run through URLDecoder these turn into spaces which means felix can't find the file you just gave it a valid file system location for. Since equinox does this correctly we can't use felix in geronimo until this is fixed.
> IIUC URLDecoder is used as an attempt to maintain compatibility with ancient vms that lack URI and its correct decoding behavior. Fortunately apache harmony implements URI so the attached patch borrows the implementation from harmony to provide correct behavior on antique vms.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2195) Using URLDecoder.decode on locations
is wrong
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated FELIX-2195:
--------------------------------
Attachment: FELIX-2195.diff
Use harmony code, not the wrong approach.
> Using URLDecoder.decode on locations is wrong
> ---------------------------------------------
>
> Key: FELIX-2195
> URL: https://issues.apache.org/jira/browse/FELIX-2195
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.4
> Reporter: David Jencks
> Attachments: FELIX-2195.diff
>
>
> URLDecoder is supposed to be for decoding form goo stuffed into a url, not for decoding the path component of a url. Using it for this produces wrong results. In partucular, mac os x likes to make temporary files with strings like "+++++++" in the path. When run through URLDecoder these turn into spaces which means felix can't find the file you just gave it a valid file system location for. Since equinox does this correctly we can't use felix in geronimo until this is fixed.
> IIUC URLDecoder is used as an attempt to maintain compatibility with ancient vms that lack URI and its correct decoding behavior. Fortunately apache harmony implements URI so the attached patch borrows the implementation from harmony to provide correct behavior on antique vms.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-2195) Using URLDecoder.decode on locations
is wrong
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls reassigned FELIX-2195:
---------------------------------
Assignee: Karl Pauls
> Using URLDecoder.decode on locations is wrong
> ---------------------------------------------
>
> Key: FELIX-2195
> URL: https://issues.apache.org/jira/browse/FELIX-2195
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.4
> Reporter: David Jencks
> Assignee: Karl Pauls
> Attachments: FELIX-2195.diff
>
>
> URLDecoder is supposed to be for decoding form goo stuffed into a url, not for decoding the path component of a url. Using it for this produces wrong results. In partucular, mac os x likes to make temporary files with strings like "+++++++" in the path. When run through URLDecoder these turn into spaces which means felix can't find the file you just gave it a valid file system location for. Since equinox does this correctly we can't use felix in geronimo until this is fixed.
> IIUC URLDecoder is used as an attempt to maintain compatibility with ancient vms that lack URI and its correct decoding behavior. Fortunately apache harmony implements URI so the attached patch borrows the implementation from harmony to provide correct behavior on antique vms.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-2195) Using URLDecoder.decode on locations
is wrong
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls resolved FELIX-2195.
-------------------------------
Resolution: Fixed
Fix Version/s: felix-3.0.0
The patch is trunk (r926330). I did massage it a bit to not depend on java5 and fit the code style. Please close if it works for you.
> Using URLDecoder.decode on locations is wrong
> ---------------------------------------------
>
> Key: FELIX-2195
> URL: https://issues.apache.org/jira/browse/FELIX-2195
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.4
> Reporter: David Jencks
> Assignee: Karl Pauls
> Fix For: felix-3.0.0
>
> Attachments: FELIX-2195.diff
>
>
> URLDecoder is supposed to be for decoding form goo stuffed into a url, not for decoding the path component of a url. Using it for this produces wrong results. In partucular, mac os x likes to make temporary files with strings like "+++++++" in the path. When run through URLDecoder these turn into spaces which means felix can't find the file you just gave it a valid file system location for. Since equinox does this correctly we can't use felix in geronimo until this is fixed.
> IIUC URLDecoder is used as an attempt to maintain compatibility with ancient vms that lack URI and its correct decoding behavior. Fortunately apache harmony implements URI so the attached patch borrows the implementation from harmony to provide correct behavior on antique vms.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.