[jira] [Commented] (HADOOP-8236) haadmin should have configurable timeouts for failover commands

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242982#comment-13242982 ] 

Hadoop QA commented on HADOOP-8236:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12520711/hadoop-8236.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/807//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/807//console

This message is automatically generated.
                
> haadmin should have configurable timeouts for failover commands
> ---------------------------------------------------------------
>
>                 Key: HADOOP-8236
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8236
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ha
>    Affects Versions: 0.23.3
>            Reporter: Philip Zeyliger
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8236.txt
>
>
> The HAAdmin failover could should time out reasonably aggressively and go onto the fencing strategies if it's dealing with a mostly dead active namenode.  Currently it uses what's probably the default, which is to say no timeout whatsoever.
> {code}
>   /**
>    * Return a proxy to the specified target service.
>    */
>   protected HAServiceProtocol getProtocol(String serviceId)
>       throws IOException {
>     String serviceAddr = getServiceAddr(serviceId);
>     InetSocketAddress addr = NetUtils.createSocketAddr(serviceAddr);
>     return (HAServiceProtocol)RPC.getProxy(
>           HAServiceProtocol.class, HAServiceProtocol.versionID,
>           addr, getConf());
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira