[GitHub] [incubator-iceberg] arina-ielchiieva opened a new pull request #443: Add null check in GenericRecord#get method to avoid failure when value is null

[GitBox <gi...@apache.org>]

arina-ielchiieva opened a new pull request #443: Add null check in GenericRecord#get method to avoid failure when value is null
URL: https://github.com/apache/incubator-iceberg/pull/443
 
 
   Issue was discovered when filtering data by column with null value:
   ```
   java.lang.IllegalStateException: Not an instance of java.lang.CharSequence: null
   
   	at org.apache.iceberg.data.GenericRecord.get(GenericRecord.java:123)
   	at org.apache.iceberg.Accessors$PositionAccessor.get(Accessors.java:57)
   	at org.apache.iceberg.Accessors$PositionAccessor.get(Accessors.java:44)
   	at org.apache.iceberg.expressions.BoundReference.get(BoundReference.java:49)
   	at org.apache.iceberg.expressions.Evaluator$EvalVisitor.eq(Evaluator.java:128)
   	at org.apache.iceberg.expressions.Evaluator$EvalVisitor.eq(Evaluator.java:58)
   	at org.apache.iceberg.expressions.ExpressionVisitors$BoundExpressionVisitor.predicate(ExpressionVisitors.java:120)
   	at org.apache.iceberg.expressions.ExpressionVisitors.visit(ExpressionVisitors.java:156)
   	at org.apache.iceberg.expressions.ExpressionVisitors.visit(ExpressionVisitors.java:171)
   	at org.apache.iceberg.expressions.ExpressionVisitors.visit(ExpressionVisitors.java:171)
   	at org.apache.iceberg.expressions.Evaluator$EvalVisitor.eval(Evaluator.java:63)
   	at org.apache.iceberg.expressions.Evaluator$EvalVisitor.access$000(Evaluator.java:58)
   	at org.apache.iceberg.expressions.Evaluator.eval(Evaluator.java:55)
   	at com.google.common.collect.Iterators$7.computeNext(Iterators.java:675)
   	at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
   	at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
   	at org.apache.iceberg.data.TableScanIterable$ScanIterator.hasNext(TableScanIterable.java:129)
   ```
   Since `instanceOf` check returns false when value is null, correct behavior would to be return null value instead of failing with `IllegalStateException` exception. Other classes which implement `StructLike` return null, only `GenericRecord` is failing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org