You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by OndrejM <gi...@git.apache.org> on 2016/07/12 14:11:48 UTC
[GitHub] deltaspike pull request #58: Fixes for Payara mnaged profile
GitHub user OndrejM opened a pull request:
https://github.com/apache/deltaspike/pull/58
Fixes for Payara mnaged profile
I identified 3 issues when running `mvn clean install -Ppayara-build-managed-4`:
- missing configuration for Payara in data module projects
- wrong assertion in Java8Test test (correct me if I'm wrong, but the lists should contain the same elements, but not necessarily in the same order)
- failing tests in ContainerCtrlTckTest
I'm sending PR for the 1st and 2nd issue. The 3rd issue remains - it seems that there is a problem with Jersey integration. Jersey cannot find a context for JNDI lookup, I will need to investigate further what is the reason. The following commit would fi the issue, but it effectively disables all the tests, as Payara Server 162 uses Weld 2.3.2.Final, which is out of specified range: https://github.com/apache/deltaspike/commit/8166155a3cbdd039b0a2b4bf2a95db3da008e1bf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/OndrejM/deltaspike master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit 8166155a3cbdd039b0a2b4bf2a95db3da008e1bf
Author: ondrejm <on...@gmail.com>
Date: 2016-07-12T06:51:50Z
Fix of failing CDI test
commit 753253cbb6757efa51a5b53c435f3577d3bb371d
Author: ondrejm <on...@gmail.com>
Date: 2016-07-12T06:52:06Z
Revert "Fix of failing CDI test"
This reverts commit 8166155a3cbdd039b0a2b4bf2a95db3da008e1bf.
commit 1ccf9b18e043996ca30c249f2f53ce0c3768b2b8
Author: ondrejm <on...@gmail.com>
Date: 2016-07-12T13:22:28Z
Fix of missing profile for Payara managed
commit a339e952e7c2ff23a2faca1b45b0336ab7ad0e92
Author: ondrejm <on...@gmail.com>
Date: 2016-07-12T13:23:08Z
Fix of incorrect assumption in the test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] deltaspike pull request #58: Fixes for Payara mnaged profile
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/58#discussion_r70447067
--- Diff: deltaspike/modules/data/test-java8/src/test/java/org/apache/deltaspike/data/test/java8/test/Java8Test.java ---
@@ -19,6 +19,7 @@
package org.apache.deltaspike.data.test.java8.test;
+import java.util.*;
--- End diff --
Please correct the wildcard import.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] deltaspike pull request #58: Fixes for Payara mnaged profile
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---