You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2018/05/17 16:41:12 UTC

[GitHub] flink pull request #6038: [FLINK-9394] [e2e] Test rescaling when resuming fr...

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/6038

    [FLINK-9394] [e2e] Test rescaling when resuming from externalized checkpoints

    ## What is the purpose of the change
    
    This PR further extends the `test_resume_externalized_checkpoints.sh` e2e test to cover rescaling cases.
    
    ## Brief change log
    
    - Allow specifying old / new parallelism and state backend configuration for the test script
    - Modify nightly test script
    
    ## Verifying this change
    
    This is a simple extension to existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-9394

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6038.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6038
    
----
commit eb738232d864f2811987927ee1ea6352a3a041f7
Author: Tzu-Li (Gordon) Tai <tz...@...>
Date:   2018-05-17T16:33:12Z

    [FLINK-9394] [e2e] Test rescaling when resuming from externalized checkpoints

----


---

[GitHub] flink issue #6038: [FLINK-9394] [e2e] Test rescaling when resuming from exte...

Posted by sihuazhou <gi...@git.apache.org>.
Github user sihuazhou commented on the issue:

    https://github.com/apache/flink/pull/6038
  
    Oh this is great! @StefanRRichter Is this means that flink plan to make checkpoint support rescaling officially in the near future?


---

[GitHub] flink issue #6038: [FLINK-9394] [e2e] Test rescaling when resuming from exte...

Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/6038
  
    r: @StefanRRichter 


---

[GitHub] flink issue #6038: [FLINK-9394] [e2e] Test rescaling when resuming from exte...

Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/6038
  
    @StefanRRichter thanks for the review, will merge this.


---

[GitHub] flink issue #6038: [FLINK-9394] [e2e] Test rescaling when resuming from exte...

Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/6038
  
    @tzulitai thanks for this additional test. LGTM 👍 


---

[GitHub] flink pull request #6038: [FLINK-9394] [e2e] Test rescaling when resuming fr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6038


---