[GitHub] [airflow] leahecole commented on a change in pull request #13810: Clarifies differences between extras and provider packages

[GitBox <gi...@apache.org>]

leahecole commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r562951209



##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -287,7 +287,7 @@ When DAGs are initialized with the ``access_control`` variable set, any usage of
     Breaking change
 
     Previously we were using two versions of UI, which were hard to maintain as we need to implement/update the same feature
-    in both versions. With this release we've removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
+    in both versions. With this release we have removed the older UI in favor of Flask App Builder RBAC UI. No need to set the

Review comment:
       Some grammar nits, recommended rewrite here:
   
   Previously we were using two versions of the UI. This was difficult to maintain, because it meant we had to implement/update features in two places. With this release, we have removed the older UI in favor of the Flask App Builder RBAC UI, reducing a huge maintenance burden. There is no longer a need to set the RBAC UI explicitly in the configuration, as it is the only default UI. 
   
   

##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -287,7 +287,7 @@ When DAGs are initialized with the ``access_control`` variable set, any usage of
     Breaking change
 
     Previously we were using two versions of UI, which were hard to maintain as we need to implement/update the same feature
-    in both versions. With this release we've removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
+    in both versions. With this release we have removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
     RBAC UI explicitly in the configuration now as this is the only default UI. We did it to avoid
     the huge maintenance burden of two independent user interfaces
 

Review comment:
       Question - is there any action that users need to take? Or is this more of an FYI doc? If there is any action, let folks know the steps here.

##########
File path: docs/apache-airflow/installation.rst
##########
@@ -70,27 +70,24 @@ Installing via ``Poetry`` or ``pip-tools`` is not currently supported. If you wi
 using those tools you should use the :ref:`constraint files <installation:constraints>`  and convert them to appropriate

Review comment:
       It won't let me comment on line 25 cuz there's no change but I wanted to let you know there's an I in PyPI that should be capitalized :) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org