You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/05/26 09:58:25 UTC
[PR] test: cover hub.component sidebar gating and routerLinks [texera]
Ma77Ball opened a new pull request, #5231:
URL: https://github.com/apache/texera/pull/5231
### What changes were proposed in this PR?
- Replace the hub.component.spec.ts smoke test with nine tests covering default-input render, GuiConfigService injection, per-flag `sidebarTabs.*_enabled` gating, all-enabled rendering, exclusion of disabled tabs, `routerLink` bindings to the three routing constants, and `isLogin` input passthrough.
- Wrap `HubComponent` in a test host `<ul nz-menu>` so `nz-menu-item` directives resolve their DI tokens the same way they do under the dashboard at runtime.
- Read `routerLink` via the directive's `routerLinkInput` signal since the `routerLink` input is a write-only setter and `ng-reflect-router-link` is not populated in the Vitest environment.
### Any related issues, documentation, or discussions?
Closes: #5224
### How was this PR tested?
- `yarn test --include='src/app/hub/component/hub.component.spec.ts'`: 9 passed, 0 failed.
- `yarn format:fix`: 506 files unchanged.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: cover hub.component sidebar gating and routerLinks [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5231:
URL: https://github.com/apache/texera/pull/5231#issuecomment-4543389078
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5231?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.54%. Comparing base ([`24f7702`](https://app.codecov.io/gh/apache/texera/commit/24f7702714800152004b98f7b01ba53244cd2eb7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c43afaf`](https://app.codecov.io/gh/apache/texera/commit/c43afafa444bf69d6cffa560479cbd770cd1ee80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5231 +/- ##
============================================
- Coverage 48.55% 48.54% -0.02%
+ Complexity 2372 2370 -2
============================================
Files 1042 1042
Lines 39971 39971
Branches 4252 4252
============================================
- Hits 19408 19403 -5
- Misses 19414 19418 +4
- Partials 1149 1150 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5231/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <ø> (ø)` | | Carriedforward from [9079dbe](https://app.codecov.io/gh/apache/texera/commit/9079dbee0c26f569322bf33ea3d2ac894d9123fb?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.48% <100.00%> (-0.04%)` | :arrow_down: | Carriedforward from [9079dbe](https://app.codecov.io/gh/apache/texera/commit/9079dbee0c26f569322bf33ea3d2ac894d9123fb?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.99% <ø> (ø)` | | Carriedforward from [9079dbe](https://app.codecov.io/gh/apache/texera/commit/9079dbee0c26f569322bf33ea3d2ac894d9123fb?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.02% <ø> (ø)` | | Carriedforward from [9079dbe](https://app.codecov.io/gh/apache/texera/commit/9079dbee0c26f569322bf33ea3d2ac894d9123fb?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.51% <ø> (ø)` | | Carriedforward from [9079dbe](https://app.codecov.io/gh/apache/texera/commit/9079dbee0c26f569322bf33ea3d2ac894d9123fb?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.81% <ø> (ø)` | | Carriedforward from [9079dbe](https://app.codecov.io/gh/apache/texera/commit/9079dbee0c26f569322bf33ea3d2ac894d9123fb?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/5231?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: cover hub.component sidebar gating and routerLinks [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball closed pull request #5231: test: cover hub.component sidebar gating and routerLinks
URL: https://github.com/apache/texera/pull/5231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org