You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2023/10/10 06:02:54 UTC
[PR] Shard-level buffer [skywalking-banyandb]
hanahmily opened a new pull request, #339:
URL: https://github.com/apache/skywalking-banyandb/pull/339
These changes improve how the buffer uses memory.
### Fix <bug description or the bug issue number or bug issue link>
- [x] Add a unit test to verify that the fix works.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shard-level buffer [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #339:
URL: https://github.com/apache/skywalking-banyandb/pull/339#issuecomment-1754461713
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#339](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4b9ad81) into [main](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/2cf42aafa3c87bd61ebbe55fb2a47f9953f8ede4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2cf42aa) will **decrease** coverage by `0.53%`.
> Report is 1 commits behind head on main.
> The diff coverage is `58.18%`.
```diff
@@ Coverage Diff @@
## main #339 +/- ##
==========================================
- Coverage 39.87% 39.34% -0.53%
==========================================
Files 111 112 +1
Lines 11938 12298 +360
==========================================
+ Hits 4760 4839 +79
- Misses 6709 6983 +274
- Partials 469 476 +7
```
| [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [banyand/tsdb/shard.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC90c2RiL3NoYXJkLmdv) | `57.07% <100.00%> (+0.66%)` | :arrow_up: |
| [banyand/tsdb/tsdb.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC90c2RiL3RzZGIuZ28=) | `53.93% <100.00%> (+0.56%)` | :arrow_up: |
| [banyand/tsdb/block.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC90c2RiL2Jsb2NrLmdv) | `50.91% <50.00%> (-0.21%)` | :arrow_down: |
| [banyand/kv/kv.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC9rdi9rdi5nbw==) | `0.00% <0.00%> (ø)` | |
| [banyand/kv/badger.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC9rdi9iYWRnZXIuZ28=) | `8.90% <65.38%> (ø)` | |
| [banyand/stream/tstable.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC9zdHJlYW0vdHN0YWJsZS5nbw==) | `0.00% <0.00%> (ø)` | |
| [banyand/measure/tstable.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC9tZWFzdXJlL3RzdGFibGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [banyand/tsdb/buffer.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmFueWFuZC90c2RiL2J1ZmZlci5nbw==) | `68.99% <67.77%> (+0.42%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shard-level buffer [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #339:
URL: https://github.com/apache/skywalking-banyandb/pull/339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org