You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/11/26 20:42:11 UTC

[GitHub] rawlinp commented on a change in pull request #3031: Add TO Go GET cdn/name/dnsseckeys, DS record txt

rawlinp commented on a change in pull request #3031: Add TO Go GET cdn/name/dnsseckeys, DS record txt
URL: https://github.com/apache/trafficcontrol/pull/3031#discussion_r236417400
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/deliveryservice/dnssec.go
 ##########
 @@ -173,9 +182,9 @@ func GetDSDomainName(dsExampleURLs []string) (string, error) {
 
 const dnssecDefaultKSKExpiration = time.Duration(365) * time.Hour * 24
 const dnssecDefaultZSKExpiration = time.Duration(30) * time.Hour * 24
-const dnssecDefaultTTL = 60
+const dnssecDefaultTTL = 30 // const dnssecDefaultTTL = 60
 
 Review comment:
   unnecessary comment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services