You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2010/03/15 14:31:24 UTC

svn commit: r923219 - in /myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component: AbstractUIForm.java AbstractUIMenuBar.java

Author: lofwyr
Date: Mon Mar 15 13:31:24 2010
New Revision: 923219

URL: http://svn.apache.org/viewvc?rev=923219&view=rev
Log:
make abstract classes really abstract

Modified:
    myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIForm.java
    myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMenuBar.java

Modified: myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIForm.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIForm.java?rev=923219&r1=923218&r2=923219&view=diff
==============================================================================
--- myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIForm.java (original)
+++ myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIForm.java Mon Mar 15 13:31:24 2010
@@ -27,17 +27,19 @@ import org.apache.myfaces.tobago.util.To
 import javax.faces.FacesException;
 import javax.faces.component.ContextCallback;
 import javax.faces.component.UIComponent;
+import javax.faces.component.UIForm;
 import javax.faces.context.FacesContext;
 import javax.faces.event.PhaseId;
 import java.util.Iterator;
 
-public class AbstractUIForm extends javax.faces.component.UIForm implements InvokeOnComponent, Form {
+public abstract class AbstractUIForm extends UIForm implements InvokeOnComponent, Form {
 
   private static final Log LOG = LogFactory.getLog(AbstractUIForm.class);
 
   public static final String COMPONENT_TYPE = "org.apache.myfaces.tobago.Form";
   public static final String SUBMITTED_MARKER = COMPONENT_TYPE + ".InSubmitted";
 
+  @Override
   public void processDecodes(FacesContext facesContext) {
 
     // Process this component first
@@ -52,6 +54,7 @@ public class AbstractUIForm extends java
     }
   }
 
+  @Override
   public void setSubmitted(boolean b) {
     super.setSubmitted(b);
 
@@ -61,6 +64,7 @@ public class AbstractUIForm extends java
     }
   }
 
+  @Override
   public void processValidators(FacesContext facesContext) {
     // if we're not the submitted form, only process subforms.
     if (LOG.isDebugEnabled()) {
@@ -80,6 +84,7 @@ public class AbstractUIForm extends java
     }
   }
 
+  @Override
   public void processUpdates(FacesContext facesContext) {
     // if we're not the submitted form, only process subforms.
     if (LOG.isDebugEnabled()) {
@@ -99,6 +104,7 @@ public class AbstractUIForm extends java
     }
   }
 
+  @Override
   public boolean invokeOnComponent(FacesContext context, String clientId, ContextCallback callback)
       throws FacesException {
     // TODO is this needed?

Modified: myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMenuBar.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMenuBar.java?rev=923219&r1=923218&r2=923219&view=diff
==============================================================================
--- myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMenuBar.java (original)
+++ myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMenuBar.java Mon Mar 15 13:31:24 2010
@@ -21,10 +21,11 @@ import org.apache.myfaces.tobago.config.
 import org.apache.myfaces.tobago.context.Markup;
 import org.apache.myfaces.tobago.renderkit.RendererBase;
 
+import javax.faces.component.UIPanel;
 import javax.faces.context.FacesContext;
 import javax.faces.render.Renderer;
 
-public class AbstractUIMenuBar extends javax.faces.component.UIPanel implements Configurable, OnComponentCreated {
+public abstract class AbstractUIMenuBar extends UIPanel implements Configurable, OnComponentCreated {
 
   // todo: may have a markup for menu bar, also may be a LayoutComponent/Container
   public Markup getMarkup() {