You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/09 11:50:52 UTC
[GitHub] [superset] codecov-io commented on pull request #13026: fix: UI toast typo
codecov-io commented on pull request #13026:
URL: https://github.com/apache/superset/pull/13026#issuecomment-775882629
# [Codecov](https://codecov.io/gh/apache/superset/pull/13026?src=pr&el=h1) Report
> Merging [#13026](https://codecov.io/gh/apache/superset/pull/13026?src=pr&el=desc) (33679c3) into [master](https://codecov.io/gh/apache/superset/commit/50fa10054fd5d2c28553c4ffd754e12bdedef5da?el=desc) (50fa100) will **increase** coverage by `9.21%`.
> The diff coverage is `65.15%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13026/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13026?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13026 +/- ##
==========================================
+ Coverage 52.64% 61.86% +9.21%
==========================================
Files 480 546 +66
Lines 17300 20153 +2853
Branches 4481 5268 +787
==========================================
+ Hits 9108 12467 +3359
+ Misses 8192 7473 -719
- Partials 0 213 +213
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.86% <65.15%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13026?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `34.78% <ø> (-49.43%)` | :arrow_down: |
| [...tend/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `75.64% <ø> (-10.26%)` | :arrow_down: |
| [...src/dashboard/components/FiltersBadge/selectors.ts](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9zZWxlY3RvcnMudHM=) | `87.65% <ø> (-2.35%)` | :arrow_down: |
| [...ters/FilterConfigModal/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwvQ2FuY2VsQ29uZmlybWF0aW9uQWxlcnQudHN4) | `100.00% <ø> (ø)` | |
| [...s/nativeFilters/FilterConfigModal/ColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwvQ29sdW1uU2VsZWN0LnRzeA==) | `47.22% <ø> (ø)` | |
| [...ts/nativeFilters/FilterConfigModal/FiltersList.tsx](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwvRmlsdGVyc0xpc3QudHN4) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...src/dashboard/util/activeDashboardNativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2FjdGl2ZURhc2hib2FyZE5hdGl2ZUZpbHRlcnMudHM=) | `96.42% <ø> (+7.53%)` | :arrow_up: |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `93.10% <ø> (+1.10%)` | :arrow_up: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `88.88% <ø> (+85.94%)` | :arrow_up: |
| ... and [484 more](https://codecov.io/gh/apache/superset/pull/13026/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13026?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13026?src=pr&el=footer). Last update [eb5dc38...33679c3](https://codecov.io/gh/apache/superset/pull/13026?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org