You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/20 18:12:42 UTC
[GitHub] [maven-ear-plugin] mabrarov opened a new pull request #31: [MEAR-294] skinnyWars & removal of provided artifacts from the Class-Path entry of MANIFEST.mf
mabrarov opened a new pull request #31:
URL: https://github.com/apache/maven-ear-plugin/pull/31
[MEAR-294] - Removal of provided artifacts from Class-Path entry of MANIFEST.mf if skinnyWars / skinnyModules options are turned on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #31: [MEAR-294] Removal of provided artifacts from the Class-Path entry of MANIFEST.mf
Posted by GitBox <gi...@apache.org>.
mabrarov commented on pull request #31:
URL: https://github.com/apache/maven-ear-plugin/pull/31#issuecomment-750737024
What about closing [MEAR-294](https://issues.apache.org/jira/browse/MEAR-294)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] elharo commented on a change in pull request #31: [MEAR-294] Removal of provided artifacts from the Class-Path entry of MANIFEST.mf
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #31:
URL: https://github.com/apache/maven-ear-plugin/pull/31#discussion_r546435418
##########
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##########
@@ -1003,8 +1003,12 @@ public void testProject091()
* <li>skinnyModules options is turned on</li>
* </ul>
* then movement of JARs and modification of manifest Class-Path entry is performed for WAR, SAR, HAR and RAR
- * modules. Additionally this test ensures that movement of JARs is not performed for modules which
- * libDirectory property doesn't point to the right module entry containing JAR libraries packaged into module.
+ * modules. Additionally this test ensures that
+ * <ul>
+ * <li>movement of JARs is not performed for modules which libDirectory property doesn't point to correct module
Review comment:
which --> whose
to correct --> to the correct
into module --> into the module
##########
File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarMojo.java
##########
@@ -317,6 +325,18 @@ public void execute()
return allJarModules;
}
+ /**
+ * @return The list of {@link #providedJarModules}. This corresponds to provided JAR modules.
Review comment:
The --> the
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #31: [MEAR-294] Removal of provided artifacts from the Class-Path entry of MANIFEST.mf
Posted by GitBox <gi...@apache.org>.
mabrarov commented on pull request #31:
URL: https://github.com/apache/maven-ear-plugin/pull/31#issuecomment-749947711
@elharo,
> Conflicts with the fix for MEAR-292, which is now committed. Please patch it up, and I'll run Jenkins.
Done. Please trigger the Jenkins job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #31: [MEAR-294] Removal of provided artifacts from the Class-Path entry of MANIFEST.mf
Posted by GitBox <gi...@apache.org>.
mabrarov commented on a change in pull request #31:
URL: https://github.com/apache/maven-ear-plugin/pull/31#discussion_r546497139
##########
File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarMojo.java
##########
@@ -317,6 +325,18 @@ public void execute()
return allJarModules;
}
+ /**
+ * @return The list of {@link #providedJarModules}. This corresponds to provided JAR modules.
Review comment:
Fixed in b9f0931
##########
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##########
@@ -1003,8 +1003,12 @@ public void testProject091()
* <li>skinnyModules options is turned on</li>
* </ul>
* then movement of JARs and modification of manifest Class-Path entry is performed for WAR, SAR, HAR and RAR
- * modules. Additionally this test ensures that movement of JARs is not performed for modules which
- * libDirectory property doesn't point to the right module entry containing JAR libraries packaged into module.
+ * modules. Additionally this test ensures that
+ * <ul>
+ * <li>movement of JARs is not performed for modules which libDirectory property doesn't point to correct module
Review comment:
Fixed in b9f0931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] elharo merged pull request #31: [MEAR-294] Removal of provided artifacts from the Class-Path entry of MANIFEST.mf
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #31:
URL: https://github.com/apache/maven-ear-plugin/pull/31
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org