You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/10 00:50:42 UTC

[GitHub] [tvm] comaniac opened a new pull request #7075: [Relay] Support deformable Conv2D NHWC

comaniac opened a new pull request #7075:
URL: https://github.com/apache/tvm/pull/7075


   PR #6999 added a TOPI compute for deformable Conv2D NHWC. This PR adds the required supports to lower NHWC deformable Conv2D from Relay so that it can be tuned by auto_scheduler.
   
   Notes:
   - I didn't find a proper place to add unit tests. Please suggest the right place if we need them.
   - This is the first time I worked on infer type. Please help review to make sure I didn't make it wrong.
   
   cc @icemelon9 @jroesch @merrymercy @vinx13 @Laurawly 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Laurawly commented on pull request #7075: [Relay] Support deformable Conv2D NHWC

Posted by GitBox <gi...@apache.org>.
Laurawly commented on pull request #7075:
URL: https://github.com/apache/tvm/pull/7075#issuecomment-742288901


   Thanks @comaniac @vinx13 !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on a change in pull request #7075: [Relay] Support deformable Conv2D NHWC

Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #7075:
URL: https://github.com/apache/tvm/pull/7075#discussion_r539776954



##########
File path: src/relay/op/nn/convolution.h
##########
@@ -1128,7 +1169,8 @@ bool DeformableConv2DRel(const Array<Type>& types, int num_inputs, const Attrs&
   } else {
     // use weight to infer the conv shape.
     if (weight == nullptr) return false;
-    auto wshape = weight->shape;
+    auto wshape = trans_kernel_layout.BackwardShape(weight->shape);

Review comment:
       Good catch. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 commented on a change in pull request #7075: [Relay] Support deformable Conv2D NHWC

Posted by GitBox <gi...@apache.org>.
vinx13 commented on a change in pull request #7075:
URL: https://github.com/apache/tvm/pull/7075#discussion_r539762513



##########
File path: src/relay/op/nn/convolution.h
##########
@@ -1128,7 +1169,8 @@ bool DeformableConv2DRel(const Array<Type>& types, int num_inputs, const Attrs&
   } else {
     // use weight to infer the conv shape.
     if (weight == nullptr) return false;
-    auto wshape = weight->shape;
+    auto wshape = trans_kernel_layout.BackwardShape(weight->shape);

Review comment:
       is it `ForwardShape`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #7075: [Relay] Support deformable Conv2D NHWC

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7075:
URL: https://github.com/apache/tvm/pull/7075#issuecomment-742194583


   > there are some test cases in `tests/python/relay/test_op_level5.py`
   
   Thanks for the pointer. Added 2 test cases to op level 5. I only added the infer type cases but not the execution because of the naive schedule on GPU.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Laurawly merged pull request #7075: [Relay] Support deformable Conv2D NHWC

Posted by GitBox <gi...@apache.org>.
Laurawly merged pull request #7075:
URL: https://github.com/apache/tvm/pull/7075


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org