You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/05/11 09:58:38 UTC

[GitHub] [echarts] behroozbc opened a new issue #14914: height is number or string

behroozbc opened a new issue #14914:
URL: https://github.com/apache/echarts/issues/14914


   ### Version
   5.1.1
   
   ### Steps to reproduce
   hi I saw gauge [example](https://echarts.apache.org/examples/en/editor.html?c=gauge-temperature) in detail set height is string but in the [type](https://github.com/apache/echarts/blob/a4df6a1fe1a5e8fb58a0e3536db07dc6f819a655/src/util/types.ts#L1049) is only number.
   
   ### What is expected?
   height type be string or number
   
   ### What is actually happening?
   height is number only
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] behroozbc commented on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
behroozbc commented on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-841233448


   @yufeng04 , @Wdingding hi 
   can I help ? and fix this example ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-842028089


   @yufeng04 Actually `detail.height` can be percent string


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] behroozbc commented on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
behroozbc commented on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-841615695


   hi @yufeng04 
   I fix it https://github.com/apache/echarts-website/pull/4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] yufeng04 commented on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
yufeng04 commented on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-841269052


   @behroozbc [Here](https://github.com/apache/echarts-website/blob/asf-site/examples/data/gauge-temperature.js#L64)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] yufeng04 edited a comment on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
yufeng04 edited a comment on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-841235231


   Welcome to join us! Just do it!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] behroozbc commented on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
behroozbc commented on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-841237173


   @yufeng04 thanks!
   where is example repository ?
   I cant find πŸ˜…πŸ˜…
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-842028089


   @yufeng04 Actually `detail.height` can be percent string


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-838192026


   Hi! We've received your issue and please be patient to get responded. πŸŽ‰
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that it contains **a minimum reproducible demo** and necessary **images** to illustrate. Otherwise, our committers will ask you to do so.
   
   *A minimum reproducible demo* should contain as little data and components as possible but can still illustrate your problem. This is the best way for us to reproduce it and solve the problem faster.
   
   You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
   
   If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 🍡


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] yufeng04 commented on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
yufeng04 commented on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-841235231


   Welcome to join us! Just do it!
   
   
   
   发θ‡ͺζˆ‘ηš„iPhone
   
   
   ------------------ Original ------------------
   From: behrooz bozorg chami ***@***.***&gt;
   Date: Fri,May 14,2021 9:09 PM
   To: apache/echarts ***@***.***&gt;
   Cc: make it right ***@***.***&gt;, Mention ***@***.***&gt;
   Subject: Re: [apache/echarts] height is number or string (#14914)
   
   
   
   
   
    
   @yufeng04 , @Wdingding hi
    can I help ? and fix this example ?
    
   β€”
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub, or unsubscribe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] yufeng04 commented on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
yufeng04 commented on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-841232133


   Sorry for your confusion. This is the error of example, the `gauge.detail.height` doesn't support string.  [Code](https://github.com/apache/echarts/blob/master/src/chart/gauge/GaugeView.ts#L631)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] behroozbc commented on issue #14914: height is number or string

Posted by GitBox <gi...@apache.org>.
behroozbc commented on issue #14914:
URL: https://github.com/apache/echarts/issues/14914#issuecomment-838215474


   https://github.com/apache/echarts/pull/14915


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org