[GitHub] [maven-scm] G-Ork commented on a change in pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit

[GitBox <gi...@apache.org>]

G-Ork commented on a change in pull request #132:
URL: https://github.com/apache/maven-scm/pull/132#discussion_r776163474



##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml
##########
@@ -88,4 +95,11 @@
       </plugin>
     </plugins>
   </build>
+  
+  <properties>
+  	<!-- jgit version: 6.0.0.202111291000-r   need java 11
+         jgit version: 5.13.0.202109080827-r  need java  8  
+  	-->
+  	<org.eclipse.jgit.version>5.13.0.202109080827-r</org.eclipse.jgit.version>

Review comment:
       It is not neccesary. I just tried to upgrade some very old dependencies. Git is evolving, JGIT shurely fixes a lot of bugs. Maven also moved to Java 8. It is paradox to fix something and keep downward compatibility while everyone moving forward. 
   
   Are there plans to upgrade the plugins to 3.x?
   
   But my heart whont bleed if keeping the old dependency. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org