You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "makssent (via GitHub)" <gi...@apache.org> on 2026/10/07 12:10:20 UTC
[PR] Fix firebird batch free close [shardingsphere]
makssent opened a new pull request, #40101:
URL: https://github.com/apache/shardingsphere/pull/40101
Changes proposed in this pull request:
- `FirebirdFreeStatementCommandExecutor` on `op_free_statement` with `DSQL_close` now unregisters the batch of the statement via `FirebirdBatchStatementManager.unregisterBatchStatement`, as it already does for `DSQL_drop` and `DSQL_unprepare`.
- A new `op_batch_create` on the same statement after `DSQL_close` creates a batch instead of failing with `isc_batch_open`.
- The prepared statement itself stays registered on `DSQL_close`.
Verification:
The same protocol packets were executed directly against a real database and through the proxy, and the results were compared.
* Server: Firebird 5.0
* Clients: Jaybird 6.0.6
Statement: `INSERT INTO T_PLAIN (ID) VALUES (?)`.
Before the fix:
| Packet | Proxy | Server | Match |
|---|---|---|---|
| `op_batch_create`: create a batch | success | success | yes |
| `op_free_statement` with `DSQL_close`: close the statement | success | success | yes |
| `op_batch_create`: create a batch of the same statement again | error 335545184 `isc_batch_open` "Batch already opened for this statement" | success | no |
| `op_batch_sync`: synchronize | success | success | yes |
| `op_batch_rls`: release the batch | success | success | yes |
| `op_batch_sync`: synchronize | success | success | yes |
After the fix:
| Packet | Proxy | Server | Match |
|---|---|---|---|
| `op_batch_create`: create a batch | success | success | yes |
| `op_free_statement` with `DSQL_close`: close the statement | success | success | yes |
| `op_batch_create`: create a batch of the same statement again | success | success | yes |
| `op_batch_sync`: synchronize | success | success | yes |
| `op_batch_rls`: release the batch | success | success | yes |
| `op_batch_sync`: synchronize | success | success | yes |
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [ ] I have specified the tool and the affected files or area for substantial AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]: https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix firebird batch free close [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #40101:
URL: https://github.com/apache/shardingsphere/pull/40101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org