[jira] Closed: (MPECLIPSE-46) Overriden jar that resides outside maven repo doesn't get resolved properly

[ji...@codehaus.org]

Message:

   The following issue has been closed.

   Resolver: David Eric Pugh
       Date: Fri, 8 Oct 2004 11:53 AM

Thanks for the fix..  
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-46

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-46
    Summary: Overriden jar that resides outside maven repo doesn't get resolved properly
       Type: Bug

     Status: Closed
   Priority: Major
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin
   Fix Fors:
             1.9
   Versions:
             1.9

   Assignee: David Eric Pugh
   Reporter: Sebastien Sahuc

    Created: Fri, 24 Sep 2004 2:08 PM
    Updated: Fri, 8 Oct 2004 11:53 AM
Environment: Win32, JDK1.4

Description:
Opening a new bug for MPECLIPSE-38 since I coudn't reopen it.

The fix for MPECLIPSE-38 is actually not working properly if the jar itself isn't located in the mavenrepo.

Let's take an example that part of our build scheme:

In the build.properties we defines the following (variable defined in maven script loader):

maven.jar.tools = ${tools.jar}

Then in the project.xml we defined the dependency:

        <dependency>
            <id>tools</id>
        </dependency>


This unfortunately ends up being wrong in the final .classpath generated by the eclipse plugin.

Here is the patch we're using for the moment until a final solution is found for those overriden jar that doesn't exist in the maven repository.

Index: classpath.jelly
===================================================================
RCS file: /home/cvspublic/maven-plugins/eclipse/src/plugin-resources/templates/classpath.jelly,v
retrieving revision 1.21
diff -u -r1.21 classpath.jelly
--- classpath.jelly 24 Sep 2004 15:51:01 -0000 1.21
+++ classpath.jelly 24 Sep 2004 17:58:02 -0000
@@ -145,6 +145,10 @@
       <j:when test="${lib.dependency.groupId == 'cactus' and ignoreCactus}">
         <!-- ignoring junit dependency as we've already created it -->
       </j:when>
+ <j:when test="${lib.dependency.id == 'tools:tools'}">
+ <!-- add tools.jar specified from maven tools.jar location -->
+ <classpathentry kind="lib" path="${lib.path}"/>
+ </j:when>
       <j:otherwise>
         <!-- make sure it's a classpath dependency -->
         <j:set var="isClasspath" value="${lib.dependency.isAddedToClasspath()}"/> 


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org