You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/05/01 12:45:43 UTC

[commons-bcel] 14/49: Clean up: else { if { ... } } -> else if { ... }

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git

commit c3367d8d64dade363148edd6b9ebb77b0f5b2924
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun May 1 08:21:06 2022 -0400

    Clean up: else { if { ... } } -> else if { ... }
---
 .../java/org/apache/bcel/verifier/structurals/ControlFlowGraph.java | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/bcel/verifier/structurals/ControlFlowGraph.java b/src/main/java/org/apache/bcel/verifier/structurals/ControlFlowGraph.java
index 0b592b1d..09671cec 100644
--- a/src/main/java/org/apache/bcel/verifier/structurals/ControlFlowGraph.java
+++ b/src/main/java/org/apache/bcel/verifier/structurals/ControlFlowGraph.java
@@ -178,10 +178,8 @@ public class ControlFlowGraph{
             if (inF == null) {// no incoming frame was set, so set it.
                 inFrames.put(lastExecutionJSR(), inFrame);
                 inF = inFrame;
-            } else {// if there was an "old" inFrame
-                if (inF.equals(inFrame) || !mergeInFrames(inFrame)) {
-                    return false;
-                }
+            } else if (inF.equals(inFrame) || !mergeInFrames(inFrame)) { // if there was an "old" inFrame
+                return false;
             }
 
             // Now we're sure the inFrame has changed!