You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/08 15:37:54 UTC
[GitHub] [camel-k] astefanutti opened a new pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
astefanutti opened a new pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092
Fixes #3091.
**Release Note**
```release-note
fix: The KameletBinding readiness condition should mirror its Integration one
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092#issuecomment-1061921177
> Out of curiosity, will this backported to a 1.8.x maintenance branch?
Yes, it's a left over from #2682 and #2719, which have been delivered in 1.8.0, so it makes sense to have it back ported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] heiko-braun commented on pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
Posted by GitBox <gi...@apache.org>.
heiko-braun commented on pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092#issuecomment-1061916975
Out of curiosity, will this backported to a 1.8.x maintenance branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092#issuecomment-1062926057
> > Yes. I didn't change the KameletBinding phases, but I'd be inclined to eventually change the `Ready` phase to `Running`.
>
> So I guess at this point, to monitor the kamelet binding we can almost ignore the phase and only rely on the conditions right ?
Right, in the KameletBinding case, that only has one condition, the phase is reduced to a condensed version of the readiness condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti merged pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092#issuecomment-1062853242
> the examples you provided the conditions are those materialized in the KameletBinding status right ?
Right.
> So to monitor the effective status of a KameletBinding the `Ready` condition should be taken into account.
Yes. I didn't change the KameletBinding phases, but I'd be inclined to eventually change the `Ready` phase to `Running`.
> if an error occurs on the deployment, i.e. it will exceed the progress limit, will an error surface ?
Yes, with that PR, the Deployment status surfaces transitively via the Integration readiness condition, into the KameletBinding readiness condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092#issuecomment-1062789440
The e2e tests that cover the above are added with 2b24202e5c0366153d037ceb059d0ead5bc4d561.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092#issuecomment-1062878965
>
> Yes. I didn't change the KameletBinding phases, but I'd be inclined to eventually change the `Ready` phase to `Running`.
>
So I guess at this point, to monitor the kamelet binding we can almost ignore the phase and only rely on the conditions right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092#issuecomment-1062788262
Here are the transitioning statuses in the _happy-path_ scenario, where a `KameletBinding` materialises into a `Deployment` resource:
```yaml
status:
conditions:
- message: Integration "timer-binding" is in "Creating" phase
reason: Creating
status: "False"
type: Ready
phase: Creating
```
```yaml
status:
conditions:
- message: Integration "timer-binding" readiness condition is "False"
reason: DeploymentProgressing
status: "False"
type: Ready
phase: Ready
```
```yaml
status:
conditions:
- message: Integration "timer-binding" readiness condition is "True"
reason: DeploymentReady
status: "True"
type: Ready
phase: Ready
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] heiko-braun commented on pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
Posted by GitBox <gi...@apache.org>.
heiko-braun commented on pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092#issuecomment-1061915850
Thanks for the quick turnaround @astefanutti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #3092: fix: The KameletBinding readiness condition should mirror its Integration one
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #3092:
URL: https://github.com/apache/camel-k/pull/3092#issuecomment-1062845877
@astefanutti
the examples you provided the conditions are those materialized in the KameletBinding status right ?
so to monitor the effective status of a KameletBinding the `Ready` condition should be taken into account.
if an error occurs on the deployment, i.e. it will exceed the progress limit, will an error surface ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org